From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6872D912DB for ; Fri, 17 Mar 2023 16:45:28 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 496C91BC56 for ; Fri, 17 Mar 2023 16:45:28 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 17 Mar 2023 16:45:26 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 58A06450D6 for ; Fri, 17 Mar 2023 16:45:26 +0100 (CET) Message-ID: Date: Fri, 17 Mar 2023 16:45:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:110.0) Gecko/20100101 Thunderbird/110.0 Content-Language: en-GB To: Proxmox Backup Server development discussion , Lukas Wagner References: <20230317084722.106090-1-l.wagner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20230317084722.106090-1-l.wagner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: [pbs-devel] applied-series: [PATCH v5 proxmox-widget-toolkit 0/5] add LDAP realm support UI X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Mar 2023 15:45:28 -0000 On 17/03/2023 09:47, Lukas Wagner wrote: > This patch series adds support for adding LDAP realms, including user sync. > > The GUI is mostly based on the implementation from PVE, with some slight > adaptations - for details, please refer to the commit messages. > The GUI components were added to the widget-toolkit repo, at some point PVE > could be adapted to use the same implemention as PBS. > > Changes v4 --> v5: > * No content changes, just rebased to current master as the patches > did not apply cleanly anymore > > Changes v3 --> v4: > * use the `let me = this` pattern in the sync ui - strictly it is not needed, > but it may prevent errors if the code is ever modified. > * Fix bug reported by Friedrich [1], where a particular combination of > attributes could trigger a `value not defined in enumeration` error > > Changes v2 --> v3: > * no changes in the UI patches > Changes v1 --> v2: > * no changes in the UI patches > > [1] https://lists.proxmox.com/pipermail/pbs-devel/2023-February/005938.html > > Versions: > > v1: https://lists.proxmox.com/pipermail/pbs-devel/2023-January/005788.html > v2: https://lists.proxmox.com/pipermail/pbs-devel/2023-January/005844.html > v3: https://lists.proxmox.com/pipermail/pbs-devel/2023-February/005914.html > v4: https://lists.proxmox.com/pipermail/pbs-devel/2023-February/005953.html > > > Lukas Wagner (5): > auth ui: add LDAP realm edit panel > auth ui: add LDAP sync UI > auth ui: add `onlineHelp` for AuthEditLDAP > auth ui: add `firstname` and `lastname` sync-attribute fields > auth ui: fix `value not defined in enumeration` error > > src/Makefile | 2 + > src/Schema.js | 12 ++ > src/panel/AuthView.js | 24 +++ > src/window/AuthEditLDAP.js | 376 +++++++++++++++++++++++++++++++++++++ > src/window/SyncWindow.js | 192 +++++++++++++++++++ > 5 files changed, 606 insertions(+) > create mode 100644 src/window/AuthEditLDAP.js > create mode 100644 src/window/SyncWindow.js > applied series, albeit I did not went for a full new in-depth review as this is currently not used and bases a lot on the quite well working code of PVE, so we can fix any nit/bug that turns up when we actually use it in PBS or switch the implementation over in PVE, thanks!