From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id D8A201FF13A for ; Wed, 29 Apr 2026 11:57:48 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B631927721; Wed, 29 Apr 2026 11:57:48 +0200 (CEST) Message-ID: Date: Wed, 29 Apr 2026 11:57:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH proxmox-backup] EncryptionKeysView: Fix API2 error alert messages To: Arthur Bied-Charreton , pbs-devel@lists.proxmox.com References: <20260428150950.50795-1-a.bied-charreton@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20260428150950.50795-1-a.bied-charreton@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777456567466 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: NC3M6Z3JIMHSRXHHPRBCGAOBHZYGIYAE X-Message-ID-Hash: NC3M6Z3JIMHSRXHHPRBCGAOBHZYGIYAE X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Code change is fine, but the metadata needs polish before this can go in, it's only the subject that should improve though: * Subject prefix should be the product area, not a JS class name. For this view we use `ui: encryption keys: ...`, see e.g. ffe55e23e, 67235b5fb. Lowercase, two-level path, separated by colons. * Lowercase imperative after the colon: "Fix" -> "fix". * The text after the prefix should describe what visibly changes for the user, not the mechanism. "Fix API2 error alert messages" hides the symptom; something like ui: encryption keys: show actual error text in API alerts instead of empty popup reads on its own in `git log` and tells a future git bisect(or) and changelog writers what this really changed without having to look at the full commit message or even the code changes. See the proxmox commit-message conventions on the dev wiki and `git log --oneline www/` for examples in this tree.