From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3DE4B61526 for ; Fri, 4 Feb 2022 17:19:25 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2D35A344EF for ; Fri, 4 Feb 2022 17:18:55 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B38B7344E3 for ; Fri, 4 Feb 2022 17:18:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7EFC545567 for ; Fri, 4 Feb 2022 17:18:54 +0100 (CET) Message-ID: Date: Fri, 4 Feb 2022 17:18:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:97.0) Gecko/20100101 Thunderbird/97.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Dominik Csapak References: <20220204095240.2278480-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220204095240.2278480-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.060 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] applied: [PATCH proxmox] proxmox-http: websocket: fix comment about callback X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Feb 2022 16:19:25 -0000 On 04.02.22 10:52, Dominik Csapak wrote: > this was once a callback in an early version, but it changed to a > channel, but the comment was not updated > > Signed-off-by: Dominik Csapak > --- > proxmox-http/src/websocket/mod.rs | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > applied, thanks! I reworded a few comments in a followup, as some where a bit hard to grasp, or used the same word relatively often in one sentence. Also dropped a doc-comment reference of "auto detecing binary/text frame" on the writer, was probably forgotten when removing that in commit 232d875