From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 57B5B65028 for ; Mon, 31 Jan 2022 15:50:46 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5008525DBC for ; Mon, 31 Jan 2022 15:50:46 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B75C325DB1 for ; Mon, 31 Jan 2022 15:50:45 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 540A745F56; Mon, 31 Jan 2022 15:50:45 +0100 (CET) Message-ID: Date: Mon, 31 Jan 2022 15:50:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:97.0) Gecko/20100101 Thunderbird/97.0 Content-Language: en-US To: Hannes Laimer , pbs-devel@lists.proxmox.com References: <20220124123159.27086-1-h.laimer@proxmox.com> <20220124123159.27086-9-h.laimer@proxmox.com> From: Dominik Csapak In-Reply-To: <20220124123159.27086-9-h.laimer@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.164 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup v5 8/8] api: tape: fix datastore lookup operations X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jan 2022 14:50:46 -0000 if you send a v6, you can ofc squash these changes into your patch where you introduce it (no need to have that change in git history) On 1/24/22 13:31, Hannes Laimer wrote: > From: Dominik Csapak > > restore needs write access, and backup only read access > > Signed-off-by: Dominik Csapak > Signed-off-by: Hannes Laimer > --- > src/api2/tape/backup.rs | 4 ++-- > src/api2/tape/restore.rs | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/api2/tape/backup.rs b/src/api2/tape/backup.rs > index 89273627..28b24168 100644 > --- a/src/api2/tape/backup.rs > +++ b/src/api2/tape/backup.rs > @@ -168,7 +168,7 @@ pub fn do_tape_backup_job( > > let worker_type = job.jobtype().to_string(); > > - let datastore = DataStore::lookup_datastore(&setup.store, Some(Operation::Write))?; > + let datastore = DataStore::lookup_datastore(&setup.store, Some(Operation::Read))?; > > let (config, _digest) = pbs_config::media_pool::config()?; > let pool_config: MediaPoolConfig = config.lookup("pool", &setup.pool)?; > @@ -349,7 +349,7 @@ pub fn backup( > &setup.drive, > )?; > > - let datastore = DataStore::lookup_datastore(&setup.store, Some(Operation::Write))?; > + let datastore = DataStore::lookup_datastore(&setup.store, Some(Operation::Read))?; > > let (config, _digest) = pbs_config::media_pool::config()?; > let pool_config: MediaPoolConfig = config.lookup("pool", &setup.pool)?; > diff --git a/src/api2/tape/restore.rs b/src/api2/tape/restore.rs > index 8ff28763..8fadbeca 100644 > --- a/src/api2/tape/restore.rs > +++ b/src/api2/tape/restore.rs > @@ -93,10 +93,10 @@ impl TryFrom for DataStoreMap { > if let Some(index) = store.find('=') { > let mut target = store.split_off(index); > target.remove(0); // remove '=' > - let datastore = DataStore::lookup_datastore(&target, Some(Operation::Read))?; > + let datastore = DataStore::lookup_datastore(&target, Some(Operation::Write))?; > map.insert(store, datastore); > } else if default.is_none() { > - default = Some(DataStore::lookup_datastore(&store, Some(Operation::Read))?); > + default = Some(DataStore::lookup_datastore(&store, Some(Operation::Write))?); > } else { > bail!("multiple default stores given"); > }