From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 183D6B35EC for ; Wed, 29 Nov 2023 07:54:50 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EFAED78F for ; Wed, 29 Nov 2023 07:54:19 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 29 Nov 2023 07:54:18 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 927C542218 for ; Wed, 29 Nov 2023 07:54:18 +0100 (CET) Message-ID: Date: Wed, 29 Nov 2023 07:54:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: pbs-devel@lists.proxmox.com References: <20231128160415.81314-1-f.ebner@proxmox.com> Content-Language: en-US From: Hannes Laimer In-Reply-To: <20231128160415.81314-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.007 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [RFC proxmox-backup] ui: sync job edit: fix showing value for target store upon edit of local sync job X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Nov 2023 06:54:50 -0000 On 11/28/23 17:04, Fiona Ebner wrote: > when editing a local sync job, the field would be empty because of > this and not be set to the previously configured remote-store. > do you mean when opening the edit window of a local sync job, or when switching between local/remote? If the former, it's a bug, but I wasn't able to reproduce it. If the later, it won't be possible to keep it when switching, the store field is the same field for local and remote, as in the job config. But it probably would make sense to rename `remote-` to `source-` as we did with the labels in the form. > The binding is already used for the local datastore, not sure why it > should even be applied to the target where it might not even be valid. >The pbsRemoteStoreSelector needs to filter the datastores if it's local since it shouldn't be possible to select the same source as target, that's how it knows which to leave out. > Signed-off-by: Fiona Ebner > --- > > Not familiar enough with the code, so sending as RFC. > > www/window/SyncJobEdit.js | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/www/window/SyncJobEdit.js b/www/window/SyncJobEdit.js > index d20def74..06d87bb2 100644 > --- a/www/window/SyncJobEdit.js > +++ b/www/window/SyncJobEdit.js > @@ -225,9 +225,6 @@ Ext.define('PBS.window.SyncJobEdit', { > allowBlank: false, > autoSelect: false, > name: 'remote-store', > - cbind: { > - datastore: '{datastore}', > - }, > listeners: { > change: function(field, value) { > let me = this;