From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 247AE609BC for ; Thu, 15 Oct 2020 18:19:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 174C014CBA for ; Thu, 15 Oct 2020 18:19:01 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A5D9614CAF for ; Thu, 15 Oct 2020 18:19:00 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6806C45DAB for ; Thu, 15 Oct 2020 18:19:00 +0200 (CEST) To: Proxmox Backup Server development discussion , Hannes Laimer References: <20201013093309.14917-1-h.laimer@proxmox.com> <20201013093309.14917-15-h.laimer@proxmox.com> From: Thomas Lamprecht Message-ID: Date: Thu, 15 Oct 2020 18:18:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:82.0) Gecko/20100101 Thunderbird/82.0 MIME-Version: 1.0 In-Reply-To: <20201013093309.14917-15-h.laimer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.132 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox-backup-proxy.rs] Subject: Re: [pbs-devel] [PATCH v3 proxmox-backup 14/14] remove old verification scheduling from proxmox-backup-proxy.rs X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Oct 2020 16:19:01 -0000 On 13.10.20 11:33, Hannes Laimer wrote: > Signed-off-by: Hannes Laimer > --- > src/bin/proxmox-backup-proxy.rs | 115 --------------------------------= > 1 file changed, 115 deletions(-) >=20 > diff --git a/src/bin/proxmox-backup-proxy.rs b/src/bin/proxmox-backup-p= roxy.rs > index e8047ecc..7993247c 100644 > --- a/src/bin/proxmox-backup-proxy.rs > +++ b/src/bin/proxmox-backup-proxy.rs > @@ -197,7 +197,6 @@ async fn schedule_tasks() -> Result<(), Error> { > =20 > schedule_datastore_garbage_collection().await; > schedule_datastore_prune().await; > - schedule_datastore_verification().await; > schedule_datastore_sync_jobs().await; > schedule_datastore_verify_jobs().await; > schedule_task_log_rotate().await; > @@ -471,120 +470,6 @@ async fn schedule_datastore_prune() { > } > } > =20 > -async fn schedule_datastore_verification() { > - use proxmox_backup::backup::{DataStore, verify_all_backups}; > - use proxmox_backup::server::{WorkerTask}; would also need a rebase, but see my other replies. Also, please do *not* but source code file endings in the commit message = or subject, makes no sense and just uglier/harder to read. This one should have rathe= r been: > proxmox-backup-proxy: remove old verification scheduling or=20 > api proxy: remove old verification scheduling