From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Christian Ebner <c.ebner@proxmox.com>
Subject: [pbs-devel] applied: [PATCH v3 proxmox-backup] client: catalog shell: avoid navigating below archive root
Date: Tue, 12 Nov 2024 21:09:09 +0100 [thread overview]
Message-ID: <c1032310-8404-4088-a249-80c534d5a332@proxmox.com> (raw)
In-Reply-To: <20240903123946.332720-1-c.ebner@proxmox.com>
Am 03.09.24 um 14:39 schrieb Christian Ebner:
> Avoid to underflow the catalogs shell position stack by navigating
> below the archives root directory into the catalog root. Otherwise
> the shell will panic, as the root entry is always expected to be
> present.
>
> This threats the archive root directory as being it's own parent
> directory, mimicking the behaviour of most common shells.
>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> Encountered while implementing the catalog shell for the split pxar
> archive case.
>
> Without this additional check, underflowing the pxar archive root of
> the catalog shell will panic.
>
> changes since version 2, thanks @Wolfgang for catching this:
> - also handle cases where the current working directory is not the root
> directory
>
> changes since version 1:
> - use `is_empty` to check if vector is empty
> - extend commit message and comment to clarify that archive root acts as
> its own parent directory
>
> pbs-client/src/catalog_shell.rs | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
>
applied, thanks!
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-11-12 20:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 12:39 [pbs-devel] " Christian Ebner
2024-11-12 20:09 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1032310-8404-4088-a249-80c534d5a332@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox