From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9E5E6B3FF0 for ; Thu, 30 Nov 2023 08:22:29 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7B46C11442 for ; Thu, 30 Nov 2023 08:21:59 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 30 Nov 2023 08:21:58 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9C33E42ACF for ; Thu, 30 Nov 2023 08:21:58 +0100 (CET) Message-ID: Date: Thu, 30 Nov 2023 08:21:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Dominik Csapak , Proxmox Backup Server development discussion References: <20231128104022.240113-1-p.hufnagl@proxmox.com> <20231128104022.240113-3-p.hufnagl@proxmox.com> From: Philipp Hufnagl In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup v3 2/3] ui: Show if Filter includes or excludes X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Nov 2023 07:22:29 -0000 On 11/28/23 14:49, Dominik Csapak wrote: > On 11/28/23 11:40, Philipp Hufnagl wrote: > [snip] >> @@ -384,6 +413,82 @@ Ext.define('PBS.form.GroupFilter', { >>       }, >>   }); >>   +Ext.define('PBS.form.pbsGroupBehaviorSelector', { >> +    extend: 'Proxmox.form.KVComboBox', >> +    alias: 'widget.pbsGroupBehaviorSelector', >> + >> +    allowBlank: false, >> + >> +    comboItems: [ >> +    ['include', gettext('Include')], >> +    ['exclude', gettext('Exclude')], >> +    ], >> +}); >> +Ext.define('PBS.form.GroupFilterGrid', { >> +    extend: 'Ext.grid.Panel', >> +    alias: 'widget.pbsGroupFilterGrid', >> + >> +    scrollable: true, >> +    height: 200, >> +    store: { >> +    fields: ['type', 'input'], >> +            }, >> +    columns: [ >> +    { >> +        text: gettext('Filter Type'), >> +        xtype: 'widgetcolumn', >> +        dataIndex: 'type', >> +        flex: 1, >> +        widget: { >> +        xtype: 'pbsGroupFilterTypeSelector', >> +        isFormField: false, >> +        }, >> +    }, >> +    { >> +        text: gettext('Filter Value'), >> +        xtype: 'widgetcolumn', >> +        flex: 1, >> +        onWidgetAttach: 'newInputColumn', >> +        widget: { >> +        padding: 0, >> +        bodyPadding: 0, >> +        xtype: 'fieldcontainer', >> +        layout: 'fit', >> +        defaults: >> +        { >> +            margin: 0, >> +        }, >> +        items: [ >> +            { >> +            hidden: true, >> +            xtype: 'pbsGroupTypeSelector', >> +            isFormField: false, >> +            }, >> +            { >> +            hidden: true, >> +            xtype: 'textfield', >> +            type: 'regex', >> +            isFormField: false, >> +            }, >> +            { >> +            hidden: true, >> +            xtype: 'pbsGroupSelector', >> +            isFormField: false, >> +            }, >> +        ], >> +        }, >> +    }, >> +    { >> +        xtype: 'widgetcolumn', >> +        width: 30, > > here you change the width of the remove button, which makes it too narrow > and cuts of the icon, please leave the space of this the same as before Ah thank you! I was wondering about that. I did not want to change it because I did not touch the vertical sizes anywhere else. I'll make a new version! > >> +        widget: { >> +        xtype: 'button', >> +        iconCls: 'fa fa-trash-o', >> +        }, >> +    }, >> +    ], >> +}); >> + >>   Ext.define('PBS.form.GroupFilterTypeSelector', { >>       extend: 'Proxmox.form.KVComboBox', >>       alias: 'widget.pbsGroupFilterTypeSelector', > >