From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C63C0C0A69 for ; Fri, 12 Jan 2024 08:35:48 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A70E11E10E for ; Fri, 12 Jan 2024 08:35:48 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 12 Jan 2024 08:35:47 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5942B4528D; Fri, 12 Jan 2024 08:35:47 +0100 (CET) Message-ID: Date: Fri, 12 Jan 2024 08:35:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Dietmar Maurer , Proxmox Backup Server development discussion References: <20240111104036.3341854-1-d.csapak@proxmox.com> <20240111104036.3341854-2-d.csapak@proxmox.com> <406216126.2803.1705044558912@webmail.proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <406216126.2803.1705044558912@webmail.proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.020 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup 1/5] tape: handle duplicate label-texts in inventory X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jan 2024 07:35:48 -0000 On 1/12/24 08:29, Dietmar Maurer wrote: > I am confused about insert_into_online_set(). We now do not add > the media to the MtxStatus, although the media is detected, only because there is another tape with the same label? > > That is far more confusing than before, isnt it? but don't actually know which of the one in the inventory it is? we only have the label and simple chose the first before, but that might be the wrong one... > >> +fn insert_into_online_set(inventory: &Inventory, label_text: &str, online_set: &mut HashSet) { >> + match inventory.find_media_by_label_text(&label_text) { >> + Ok(Some(media_id)) => { >> + online_set.insert(media_id.label.uuid.clone()); >> + } >> + Ok(None) => {} >> + Err(err) => log::warn!("error getting media by unique label: {err}"), >> + } >> +} >> + >> /// Extract the list of online media from MtxStatus >> /// >> /// Returns a HashSet containing all found media Uuid. This only >> @@ -96,9 +106,7 @@ pub fn mtx_status_to_online_set(status: &MtxStatus, inventory: &Inventory) -> Ha >>