From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D23949A0FA for ; Thu, 12 Oct 2023 11:29:11 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A843C1173F for ; Thu, 12 Oct 2023 11:28:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 12 Oct 2023 11:28:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id F1D3344A12; Thu, 12 Oct 2023 11:28:39 +0200 (CEST) Message-ID: Date: Thu, 12 Oct 2023 11:28:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Proxmox Backup Server development discussion , Gabriel Goller References: <20230913142045.240835-1-g.goller@proxmox.com> From: Dominik Csapak In-Reply-To: <20230913142045.240835-1-g.goller@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.011 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix: ui: spinner position X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Oct 2023 09:29:11 -0000 On 9/13/23 16:20, Gabriel Goller wrote: > When displaying the status of a job (sync, gc, etc..) the 'OK' > and 'Error' text uses a padding of 10px to the left. The > loading spinner is centered in the cell though. This doesn't > look that good. this is debatable, and having the 'loading' state stand out, makes sense imo. *if* we want to change this, we either would have to adapt pve/pmg as well, or refactor the class into the widget-toolkit (idk if there are some differences across products, though it shouldn't be), because we also use that for the task and job status list (e.g. replication) > > Signed-off-by: Gabriel Goller > --- > www/css/ext6-pbs.css | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/www/css/ext6-pbs.css b/www/css/ext6-pbs.css > index 5fd65d25..4a4a41be 100644 > --- a/www/css/ext6-pbs.css > +++ b/www/css/ext6-pbs.css > @@ -81,7 +81,7 @@ > > /* loading in task list */ > .x-grid-row-loading { > - background: no-repeat center center; > + background: no-repeat left 10px center; > background-image:url(../extjs/theme-crisp/resources/images/loadmask/loading.gif); > } >