From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id ECA4B611D8 for ; Fri, 18 Feb 2022 10:45:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DBD882838A for ; Fri, 18 Feb 2022 10:45:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 9A1F32837D for ; Fri, 18 Feb 2022 10:45:10 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6CCA446282 for ; Fri, 18 Feb 2022 10:45:10 +0100 (CET) Message-ID: Date: Fri, 18 Feb 2022 10:45:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Dominik Csapak References: <20220217135040.512359-1-d.csapak@proxmox.com> From: Dietmar Maurer In-Reply-To: <20220217135040.512359-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.465 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] applied: [PATCH proxmox-backup] tape/pool_writer: skip already backed up chunks in iterator X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Feb 2022 09:45:42 -0000 applied with minor cleanups.. On 2/17/22 14:50, Dominik Csapak wrote: > currently, the iterator goes over *all* chunks of the index, even > those already backed up by a previous snapshots in the same tape > backup. this is bad since for each iterator, we stat each chunk to > sort by inode number. so to avoid stat'ing the same chunks over > and over for consecutive snapshots, add a 'skip_fn' to the iterator > and in the pool writer and check the catalog_set if we can skip it > > this means we can drop the later check for the catalog_set > (since we don't modify that here)