From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 194B3921F3 for ; Fri, 10 Feb 2023 11:30:53 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8E3FE2E5A8 for ; Fri, 10 Feb 2023 11:30:52 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 10 Feb 2023 11:30:51 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A73D946759 for ; Fri, 10 Feb 2023 11:30:49 +0100 (CET) Message-ID: Date: Fri, 10 Feb 2023 11:30:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 To: Proxmox Backup Server development discussion , =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= References: <20230209133128.695211-1-l.wagner@proxmox.com> <20230209133128.695211-11-l.wagner@proxmox.com> <1676023936.ktlvuvehan.astroid@yuna.none> Content-Language: en-US From: Lukas Wagner In-Reply-To: <1676023936.ktlvuvehan.astroid@yuna.none> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.390 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.149 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH v3 proxmox-backup 10/18] manager: add commands for managing LDAP realms X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Feb 2023 10:30:53 -0000 Thanks for the feedback, Fabian! On 2/10/23 11:16, Fabian Grünbichler wrote: >> + proxmox_rest_server::handle_worker(upid).await?; >> + } >> + } > > possibly late to the party given that the "handle_worker" move got applied already.. > > is there a good reason for introducing this instead of calling the endpoint over > the API and using the "I just spawned a task and want to poll the output" helper > (pbs_client::view_task_result), like the rest of proxmox-backup-manager does? > Good point. I missed that the functionality was already present ;). I used the debug-cli client as guidance, since that was what I was using for early testing. It would probably make sense to change it then? -- - Lukas