From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A8CFD9B8A for ; Mon, 26 Jun 2023 14:39:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 85BFD2832F for ; Mon, 26 Jun 2023 14:39:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 26 Jun 2023 14:39:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D66FA44020 for ; Mon, 26 Jun 2023 14:39:03 +0200 (CEST) Message-ID: Date: Mon, 26 Jun 2023 14:39:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Stefan Sterz References: <20230626093916.701659-1-s.sterz@proxmox.com> From: Lukas Wagner In-Reply-To: <20230626093916.701659-1-s.sterz@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.097 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.089 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox(-backup), widget-toolkit 0/4] improve ldap configuration handling X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jun 2023 12:39:34 -0000 Heya, reviewed these changes and tested them on the respective latest master branches. Tested against a `glauth` instance running on my local machine. Seems to work as advertised. Code looks good to me. Some comments were posted in reply to the individual patches, but nothing that prohibits a merge IMO. Consider this: Tested-by: Lukas Wagner Reviewed-by: Lukas Wagner On 6/26/23 11:39, Stefan Sterz wrote: > this patch series does two things: > > 1. it improves the creation and updating of ldap configurations by > checking it against an ldap directory instead of a regex. thus, > increasing the likelihood of the configuration being correct > 2. remove the ability configure and use unauthenticated binds. > unauthenticated binds are generally discouraged and we don't > support them in proxmox ve either, so remove them in the backup > server too. > > removing unauthenticated binds is a breaking change as some users may > already rely on this functionality. > > Stefan Sterz (1): > window: ldap auth edit forbid specifying a bind_dn without a password > > src/window/AuthEditLDAP.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > -- - Lukas