From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4AB257B07A for ; Thu, 7 Jul 2022 11:06:32 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 463781CBE1 for ; Thu, 7 Jul 2022 11:06:32 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 7 Jul 2022 11:06:31 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 100DB43DD1 for ; Thu, 7 Jul 2022 11:06:25 +0200 (CEST) Message-ID: Date: Thu, 7 Jul 2022 11:06:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Wolfgang Bumiller Cc: pbs-devel@lists.proxmox.com References: <20220705130834.14285-1-h.laimer@proxmox.com> <20220705130834.14285-10-h.laimer@proxmox.com> <20220706113552.gw2ifzp4reib2hch@casey.proxmox.com> From: Hannes Laimer In-Reply-To: <20220706113552.gw2ifzp4reib2hch@casey.proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.041 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup 07/26] api2: datastore create: don't init chunkstore if removable X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jul 2022 09:06:32 -0000 Am 06.07.22 um 13:35 schrieb Wolfgang Bumiller: > On Tue, Jul 05, 2022 at 01:08:15PM +0000, Hannes Laimer wrote: >> .. instead set the maintenance mode to unplugged. So on creation every >> removable datastore is unplugged until a removable device is associated >> with it. > > As a continuation of my design question: if we were to include the > removable device info right in the datastore, we could just drop the > late initialization code altogether IMO. Yes, but we will have to do it also in a another place as soon as we add a seconds removable device. So by moving the initialization to the mounting process we have it in just one place. > > Actually, we can drop it regardless IMO. When do you really need to > declare a datastore before adding the devices for it? Is that really > something we need? If we have a PBS and want to use a removable device that contains data that was written by another PBS we have to be able to create a datastore without creating the chunkstore on the device.