From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 4D8151FF166 for ; Fri, 25 Oct 2024 12:44:53 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B039F1DF25; Fri, 25 Oct 2024 12:44:53 +0200 (CEST) Message-ID: Date: Fri, 25 Oct 2024 12:44:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox Backup Server development discussion , Christian Ebner References: <20241018084242.144010-1-c.ebner@proxmox.com> <20241018084242.144010-25-c.ebner@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20241018084242.144010-25-c.ebner@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH v5 proxmox-backup 24/31] ui: sync view: do not use data model proxy for store X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" one comment inline On 10/18/24 10:42, Christian Ebner wrote: > In order to load data using the same model from different sources, > set the proxy on the store instead of the model. > This allows to use the view to display sync jobs in either pull or > push direction, by setting the additional `sync-direction` parameter > to the proxy's api calls. > > Signed-off-by: Christian Ebner > --- > changes since version 4: > - no changes > > changes since version 3: > - no changes > > www/config/SyncView.js | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/www/config/SyncView.js b/www/config/SyncView.js > index 981b9b251..39e464fc5 100644 > --- a/www/config/SyncView.js > +++ b/www/config/SyncView.js > @@ -16,10 +16,6 @@ Ext.define('pbs-sync-jobs-status', { > 'comment', > ], > idProperty: 'id', > - proxy: { > - type: 'proxmox', > - url: '/api2/json/admin/sync', > - }, > }); > > Ext.define('PBS.config.SyncJobView', { > @@ -160,9 +156,12 @@ Ext.define('PBS.config.SyncJobView', { > sorters: 'id', > rstore: { > type: 'update', > - storeid: 'pbs-sync-jobs-status', why is the storeid here removed? the commit message does not mentions this > model: 'pbs-sync-jobs-status', > interval: 5000, > + proxy: { > + type: 'proxmox', > + url: '/api2/json/admin/sync', > + }, > }, > }, > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel