From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 08A4E67BDB for ; Tue, 10 Nov 2020 14:15:50 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F338F21AFD for ; Tue, 10 Nov 2020 14:15:19 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id C56DF21ADF for ; Tue, 10 Nov 2020 14:15:18 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 913E246046 for ; Tue, 10 Nov 2020 14:15:18 +0100 (CET) To: Thomas Lamprecht , Proxmox Backup Server development discussion References: <20201110123850.21491-1-a.lauterer@proxmox.com> <20201110123850.21491-2-a.lauterer@proxmox.com> <4d5c6c92-ff04-ece6-9662-cbc3939d3d16@proxmox.com> From: Aaron Lauterer Message-ID: Date: Tue, 10 Nov 2020 14:15:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <4d5c6c92-ff04-ece6-9662-cbc3939d3d16@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.008 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 2/3] ui: onlinehelp update with sysadmin_host_administration X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Nov 2020 13:15:50 -0000 This was phrased a bit confusing. This was not removed manually but when I ran a `make OnlineHelpInfo.js` they were removed. So yeah, no idea why they were added in the first place but there is something going on that I do not fully understand yet but definitely a result of the quick hack to not scan the JS source files for help keys that are actually in use. On 11/10/20 1:53 PM, Thomas Lamprecht wrote: > On 10.11.20 13:38, Aaron Lauterer wrote: >> also remove some rst refs that slipped in >> > > why?? this is an autogenerated file which we want to track in git, nothing slipped > in here. Do not remove things manually which then just get re-added on each make > OnlineHelpInfo call, producing a dirty git state.. > > I dropped the wrong removes, the correct fix for this is to fix the onlineHelp > scanner, which then drops this automatically. > >> Signed-off-by: Aaron Lauterer >> --- >> www/OnlineHelpInfo.js | 40 ++++------------------------------------ >> 1 file changed, 4 insertions(+), 36 deletions(-) >> >> diff --git a/www/OnlineHelpInfo.js b/www/OnlineHelpInfo.js >> index a9683874..c54912d8 100644 >> --- a/www/OnlineHelpInfo.js >> +++ b/www/OnlineHelpInfo.js >> @@ -75,42 +75,6 @@ const proxmoxOnlineHelpInfo = { >> "link": "/docs/pve-integration.html#pve-integration", >> "title": "`Proxmox VE`_ Integration" >> }, >> - "rst-primer": { >> - "link": "/docs/reStructuredText-primer.html#rst-primer", >> - "title": "reStructuredText Primer" >> - }, >> - "rst-inline-markup": { >> - "link": "/docs/reStructuredText-primer.html#rst-inline-markup", >> - "title": "Inline markup" >> - }, >> - "rst-literal-blocks": { >> - "link": "/docs/reStructuredText-primer.html#rst-literal-blocks", >> - "title": "Literal blocks" >> - }, >> - "rst-doctest-blocks": { >> - "link": "/docs/reStructuredText-primer.html#rst-doctest-blocks", >> - "title": "Doctest blocks" >> - }, >> - "rst-tables": { >> - "link": "/docs/reStructuredText-primer.html#rst-tables", >> - "title": "Tables" >> - }, >> - "rst-field-lists": { >> - "link": "/docs/reStructuredText-primer.html#rst-field-lists", >> - "title": "Field Lists" >> - }, >> - "rst-roles-alt": { >> - "link": "/docs/reStructuredText-primer.html#rst-roles-alt", >> - "title": "Roles" >> - }, >> - "rst-directives": { >> - "link": "/docs/reStructuredText-primer.html#rst-directives", >> - "title": "Directives" >> - }, >> - "html-meta": { >> - "link": "/docs/reStructuredText-primer.html#html-meta", >> - "title": "HTML Metadata" >> - }, >> "storage-disk-management": { >> "link": "/docs/storage.html#storage-disk-management", >> "title": "Disk Management" >> @@ -123,6 +87,10 @@ const proxmoxOnlineHelpInfo = { >> "link": "/docs/storage.html#storage-datastore-create", >> "title": "Creating a Datastore" >> }, >> + "sysadmin-host-administration": { >> + "link": "/docs/sysadmin.html#sysadmin-host-administration", >> + "title": "Host System Administration" >> + }, >> "user-mgmt": { >> "link": "/docs/user-management.html#user-mgmt", >> "title": "User Management" >> > >