From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A66F01FF146 for ; Tue, 28 Apr 2026 16:14:24 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 785621554A; Tue, 28 Apr 2026 16:14:24 +0200 (CEST) Message-ID: Date: Tue, 28 Apr 2026 16:13:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH v1 proxmox-backup 1/3] datastore: read ctime from didx header instead of using current time To: Robert Obkircher , pbs-devel@lists.proxmox.com References: <20260428122544.19899-1-r.obkircher@proxmox.com> <20260428122544.19899-2-r.obkircher@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20260428122544.19899-2-r.obkircher@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777385534322 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.051 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: KVXZFCWISHN2P5ZRKMCLKQSIHAGCGQ3C X-Message-ID-Hash: KVXZFCWISHN2P5ZRKMCLKQSIHAGCGQ3C X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 4/28/26 2:25 PM, Robert Obkircher wrote: > It looks like this was accidentally changed during a refactor in 2020. > > The ctime field is public, so it is not obvious whether anyone depends > on the broken behavior. The index_ctime accessor only seems to be used > by inspect_file in proxmox_backup_debug. not a review, but I made the ctime field private and compiled with `cargo build --all` and `cargo test --all` and it showed now errors, so we can assume this field was never used directly only via the index_ctime accessor that said, the fix LGTM > > Fixes: 6a7be83efe ("avoid chrono dependency, depend on proxmox 0.3.8") > Signed-off-by: Robert Obkircher > --- > pbs-datastore/src/dynamic_index.rs | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/pbs-datastore/src/dynamic_index.rs b/pbs-datastore/src/dynamic_index.rs > index e1ca0eae..288f38b5 100644 > --- a/pbs-datastore/src/dynamic_index.rs > +++ b/pbs-datastore/src/dynamic_index.rs > @@ -119,8 +119,6 @@ impl DynamicIndexReader { > bail!("got unknown magic number"); > } > > - let ctime = proxmox_time::epoch_i64(); > - > let index_size = stat.st_size as usize - header_size; > let index_count = index_size / 40; > if index_count * 40 != index_size { > @@ -141,7 +139,7 @@ impl DynamicIndexReader { > _file: file, > size, > index, > - ctime, > + ctime: header.ctime, > uuid: header.uuid, > index_csum: header.index_csum, > })