From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9BE03B8CBD for ; Wed, 6 Dec 2023 14:29:32 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7C663277A for ; Wed, 6 Dec 2023 14:29:02 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 6 Dec 2023 14:29:01 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A733C42501 for ; Wed, 6 Dec 2023 14:29:01 +0100 (CET) Message-ID: Date: Wed, 6 Dec 2023 14:29:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US From: Gabriel Goller To: pbs-devel@lists.proxmox.com Reply-To: Proxmox Backup Server development discussion References: <20231204131820.204423-1-g.goller@proxmox.com> In-Reply-To: <20231204131820.204423-1-g.goller@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.158 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox{, -backup} 0/2] Move ProcessLocker to tmpfs X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Dec 2023 13:29:32 -0000 Submitted a new patch! On 12/4/23 14:18, Gabriel Goller wrote: > This moves the `ProcessLocker`'s `.lock` file to `/run/proxmox-backup/locks` (tmpfs). > > The first patch only converts all the `F_SETLK` flags to `F_OFD_SETLK` flags. This > changes normal locks, which are based on the process, to locks based on an open file > descriptor. This actually doesn't change anything, because we use mutexes, so the > lock is already thread-safe. It would be cleaner though and would safe us from > weird quirks like closing the lock-file which would drop all the locks when using > the POSIX `F_SETLK`. See more here [0]. > > The second patch changes the location of the `.lock` file to the `/run/proxmox-backup/locks` > tmpfs directory. Like this we don't need to lazy-lock anything and we can keep the lockfile > open all the time. Unmounting datastores is now possible as the lock file is not on the > datastore mount anymore. > > Another thing is noticed is that datastores that are not available (e.g. have been unmounted) > don't display an error on the ui. That means the only way to see if a datastore is online is > to either start a gc or verify run. An idea for a future patch would be to check if the > datastore exists and (maybe) even automatically set the maintenance mode to `offline` if it > doesn't exist? > > [0]: https://man7.org/linux/man-pages/man2/fcntl.2.html > > > > proxmox: > > Gabriel Goller (1): > process_locker: use ofd locking > > proxmox-sys/src/process_locker.rs | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > > proxmox-backup: > > Gabriel Goller (1): > datastore: store datastore lock on tmpfs > > pbs-datastore/src/chunk_store.rs | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > > Summary over all repositories: > 2 files changed, 17 insertions(+), 14 deletions(-) >