From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B041A1FF13F for ; Thu, 09 Apr 2026 10:27:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1BFA71AD1D; Thu, 9 Apr 2026 10:28:24 +0200 (CEST) Message-ID: Date: Thu, 9 Apr 2026 10:28:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox-backup v8 04/17] ui: expose s3 request counter statistics in the datastore summary To: Dominik Csapak , pbs-devel@lists.proxmox.com References: <20260402105333.463088-1-c.ebner@proxmox.com> <20260402105333.463088-5-c.ebner@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775723232533 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.068 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: THEQE3K3DN5SOPAW2JZTO7OCZMEGKO5T X-Message-ID-Hash: THEQE3K3DN5SOPAW2JZTO7OCZMEGKO5T X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 4/9/26 10:20 AM, Dominik Csapak wrote: > Looked at this a bit, and I think this is a bit crammed. > Especially the comment panel looks a bit weird when it's collapsed. > > I'd propose switching the positions of s3 and comment, and make > the comment a full column wide in case it's an s3 datastore > > this makes it look less cramped. also users in the past > wanted more space for the comments already, so making > it smaller in some cases is not good i think. Thanks for the suggestion, this was also contested by Thomas off-list! Switching and making the notes a full column sounds good, will see how to do that best conditionally.