From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 2B2A41FF13F for ; Thu, 12 Mar 2026 15:40:48 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7DF721C126; Thu, 12 Mar 2026 15:40:44 +0100 (CET) Message-ID: Date: Thu, 12 Mar 2026 15:40:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox v5 05/13] s3-client: add counters for upload/download traffic To: Hannes Laimer , pbs-devel@lists.proxmox.com References: <20260311130823.724888-1-c.ebner@proxmox.com> <20260311130823.724888-6-c.ebner@proxmox.com> <4d7f81dc-8bae-4942-8eba-c19785c9a42c@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <4d7f81dc-8bae-4942-8eba-c19785c9a42c@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773326375106 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.057 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: M7PERETP5X7Q3JN3B4WCVIBE3WXGFWJT X-Message-ID-Hash: M7PERETP5X7Q3JN3B4WCVIBE3WXGFWJT X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 3/12/26 3:28 PM, Hannes Laimer wrote: > do we want to also `reset` bytes, cause the reset api endpoint does not > currently? We have thresholds, but we don't seem to check them, so no I > guess. On the other hand, given the current implementation it looks like > they are intended to behave like the counter ones. Yes, indeed! The uploaded/downloaded traffic should be reset as well, will adapt that, thanks! In general, I still plan to include a schedule based resetting, so users can configure to e.g. perform a monthly reset of the counters. > > > On 2026-03-11 14:08, Christian Ebner wrote: >> In addition to accounting for requests, also allow to track the >> number of bytes uploaded or downloaded via the s3 clients. >> >> With the intention to estimate shared upload/download bandwidth in >> Proxmox Backup Server as well as easily estimate the total traffic >> volume. >> >> Signed-off-by: Christian Ebner >> --- >> .../src/shared_request_counters.rs | 63 +++++++++++++++++++ >> 1 file changed, 63 insertions(+) >> >> diff --git a/proxmox-s3-client/src/shared_request_counters.rs b/proxmox-s3-client/src/shared_request_counters.rs >> index edd1df3d..a5cd286c 100644 >> --- a/proxmox-s3-client/src/shared_request_counters.rs >> +++ b/proxmox-s3-client/src/shared_request_counters.rs >> @@ -37,6 +37,9 @@ struct RequestCounters { >> put: AlignedAtomic, >> head: AlignedAtomic, >> post: AlignedAtomic, >> + // traffic in bytes >> + upload: AlignedAtomic, >> + download: AlignedAtomic, >> } >> >> impl Init for RequestCounters { >> @@ -81,6 +84,30 @@ impl RequestCounters { >> self.post.0.store(0, ordering); >> self.put.0.store(0, ordering); >> } >> + >> + /// Account for new upload traffic. >> + /// >> + /// Returns the previously stored value. >> + pub fn add_upload_traffic(&self, count: u64, ordering: Ordering) -> u64 { >> + self.upload.0.fetch_add(count, ordering) >> + } >> + >> + /// Returns upload traffic count. >> + pub fn get_upload_traffic(&self, ordering: Ordering) -> u64 { >> + self.upload.0.load(ordering) >> + } >> + >> + /// Account for new download traffic. >> + /// >> + /// Returns the previously stored value. >> + pub fn add_download_traffic(&self, count: u64, ordering: Ordering) -> u64 { >> + self.download.0.fetch_add(count, ordering) >> + } >> + >> + /// Returns download traffic count. >> + pub fn get_download_traffic(&self, ordering: Ordering) -> u64 { >> + self.download.0.load(ordering) >> + } >> } >> >> /// Size of the padding to align the mmapped request counters to 4k default >> @@ -180,4 +207,40 @@ impl SharedRequestCounters { >> pub fn reset(&self, ordering: Ordering) { >> self.shared_memory.data().counters.reset(ordering) >> } >> + >> + /// Account for new upload traffic. >> + /// >> + /// Returns the previously stored value. >> + pub fn add_upload_traffic(&self, count: u64, ordering: Ordering) -> u64 { >> + self.shared_memory >> + .data() >> + .counters >> + .add_upload_traffic(count, ordering) >> + } >> + >> + /// Returns upload traffic count. >> + pub fn get_upload_traffic(&self, ordering: Ordering) -> u64 { >> + self.shared_memory >> + .data() >> + .counters >> + .get_upload_traffic(ordering) >> + } >> + >> + /// Account for new download traffic. >> + /// >> + /// Returns the previously stored value. >> + pub fn add_download_traffic(&self, count: u64, ordering: Ordering) -> u64 { >> + self.shared_memory >> + .data() >> + .counters >> + .add_download_traffic(count, ordering) >> + } >> + >> + /// Returns download traffic count. >> + pub fn get_download_traffic(&self, ordering: Ordering) -> u64 { >> + self.shared_memory >> + .data() >> + .counters >> + .get_download_traffic(ordering) >> + } >> } >