From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BC8C661151 for ; Tue, 20 Oct 2020 10:35:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B9BBEBCB4 for ; Tue, 20 Oct 2020 10:35:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 19A33BCA7 for ; Tue, 20 Oct 2020 10:35:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D7DC145E10 for ; Tue, 20 Oct 2020 10:35:48 +0200 (CEST) To: Proxmox Backup Server development discussion , Hannes Laimer References: <20201020070015.29366-1-h.laimer@proxmox.com> From: Thomas Lamprecht Message-ID: Date: Tue, 20 Oct 2020 10:35:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:82.0) Gecko/20100101 Thunderbird/82.0 MIME-Version: 1.0 In-Reply-To: <20201020070015.29366-1-h.laimer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.130 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, datastore.rs] Subject: Re: [pbs-devel] [PATCH v1 proxmox-backup] remove not used argument config from open with path X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Oct 2020 08:35:49 -0000 On 20.10.20 09:00, Hannes Laimer wrote: > Signed-off-by: Hannes Laimer > --- > > Building failed since the import of DataStoreConfig was missing, > furthermore config was not used in the function. > > src/backup/datastore.rs | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/backup/datastore.rs b/src/backup/datastore.rs > index a856e2f4..47531bbf 100644 > --- a/src/backup/datastore.rs > +++ b/src/backup/datastore.rs > @@ -57,7 +57,7 @@ impl DataStore { > } > } > > - let datastore = DataStore::open_with_path(name, &path, config)?; > + let datastore = DataStore::open_with_path(name, &path)?; > > let datastore = Arc::new(datastore); > map.insert(name.to_string(), datastore.clone()); > @@ -65,7 +65,7 @@ impl DataStore { > Ok(datastore) > } > > - fn open_with_path(store_name: &str, path: &Path, config: DataStoreConfig) -> Result { > + fn open_with_path(store_name: &str, path: &Path) -> Result { > let chunk_store = ChunkStore::open(store_name, path)?; > > let gc_status = GarbageCollectionStatus::default(); > looks actually OK and thanks for catching, but it seems Fabian got to it earlier, and pushed out a fix: https://git.proxmox.com/?p=proxmox-backup.git;a=commitdiff;h=115d927c15f8c70442de7cc3a43e99587b499c26