From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A9FC461455 for ; Wed, 9 Feb 2022 13:54:10 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 96C94F33 for ; Wed, 9 Feb 2022 13:53:40 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 42EABF25 for ; Wed, 9 Feb 2022 13:53:39 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0E25A46869; Wed, 9 Feb 2022 13:53:39 +0100 (CET) Message-ID: Date: Wed, 9 Feb 2022 13:53:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:97.0) Gecko/20100101 Thunderbird/97.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Matthias Heiserer References: <20220207111903.1953333-1-m.heiserer@proxmox.com> <20220207111903.1953333-3-m.heiserer@proxmox.com> From: Dominik Csapak In-Reply-To: <20220207111903.1953333-3-m.heiserer@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.160 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup 3/3] GUI option for node.cfg default-lang X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Feb 2022 12:54:10 -0000 On 2/7/22 12:19, Matthias Heiserer wrote: > Signed-off-by: Matthias Heiserer > --- > www/config/NodeOptionView.js | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/www/config/NodeOptionView.js b/www/config/NodeOptionView.js > index 64f3d792..24458058 100644 > --- a/www/config/NodeOptionView.js > +++ b/www/config/NodeOptionView.js > @@ -42,7 +42,16 @@ Ext.define('PBS.NodeOptionView', { > vtype: 'proxmoxMail', > deleteEmpty: true, > }, > - > + { > + xtype: 'combobox', > + name: 'default-lang', > + text: gettext('Default language'), > + defaultValue: 'English', > + // skip the 'default' item. It's not possible to delete the default > + // language from the GUI, but setting it to 'en' has the same result > + comboItems: Proxmox.Utils.language_array().slice(1), we can do better here, namely we can use '__default__' as the defaulValue. the combobox handles this like an empty one and sends '"delete":"default-lang"' to the backend then, we should add the renderer too: renderer: Proxmox.Utils.render_language for now, this will not properly render '__default__', but it should be easy to patch that in proxmox-widget-toolkit ;) > + deleteEmpty: true, > + }, > ], > > initComponent: function() {