From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 58C2D1FF16B for ; Fri, 21 Nov 2025 15:15:24 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F024B22F58; Fri, 21 Nov 2025 15:15:30 +0100 (CET) Message-ID: Date: Fri, 21 Nov 2025 15:15:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Christian Ebner To: Proxmox Backup Server development discussion , Nicolas Frey References: <20251121123209.198368-1-n.frey@proxmox.com> Content-Language: en-US, de-DE In-Reply-To: <20251121123209.198368-1-n.frey@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763734495337 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [RFC/PATCH proxmox{, -backup} 0/5] tuning: verify: add verify job thread options X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 11/21/25 1:32 PM, Nicolas Frey wrote: > this patch series aims to expose configuration of the number of threads > to use for reading and verifying of verify jobs through the datastore's > tuning options. > > It expands on the series I sent last week [0], where @Thomas > suggested making this configurable through the tuning options too. > @Chris suggested adding a dedicated worker thread settings to the > datastore instead, which is an approach I don't have a problem with, > but I'd want some more opinions on. > > If the docs should be updated to account for this change, I can either > send a follow up or do that in a v2. > > Later down the line, it would also be beneficial to add the tape job > threads to these options, though that is outside of the scope of this > series. > > [0] https://lore.proxmox.com/pbs-devel/5a731352-1f77-4b15-9a22-7064b70ce519@proxmox.com/T/#t Nice work! Gave this series a quick spin an tested: - that the settings are applied - edit fields show and update the configured default - settings are deleted if removed from the config - verification tasks pick up the configured values - cli commands for datastore config and verify work as expected What is still missing is adapting the render_tuning_options in www/Utils.js to cover these new parameters as well and adaption to the docs. Other than that with and a few nit inline to be addressed: Reviewed-by: Christian Ebner Tested-by: Christian Ebner _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel