Re: [PATCH proxmox-widget-toolkit v4 11/24] utils: Add OAuth2 flow handlers

Shannon Sterz
2026-04-24T08:54:18Z

On Fri Apr 24, 2026 at 10:44 AM CEST, Arthur Bied-Charreton wrote:
> On Thu, Apr 23, 2026 at 02:24:32PM +0200, Shannon Sterz wrote:
>> On Tue Apr 21, 2026 at 1:59 PM CEST, Arthur Bied-Charreton wrote:

-->8 snip 8<--

>> also if i remember correctly there was an issue with using the async
>> fetch api in extjs, maybe @Dominik Csapak could take a look if this is
>> fine here.
>>
>
> I had a talk with Dominik off-list, async calls are indeed often an
> issue in Ext.js, because it does not detect async functions, meaning it
> may treat functions defined as async the same way it would treat
> synchronous ones. This can lead to issues where e.g. a function that is
> expected to be sync and return a string returns a promise instead,
> breaking Ext.js' handling of the return value.
>
> This is however not an issue here, because this is only called in the
> SmtpEditPanel's Authorize button handler, which is defined as async and
> expected by Ext.js to be async, so it will be properly awaited.

ah makes sense, sorry i couldn't remember the details here anymore,
thanks for looking into it!

-->8 snip 8<--