From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id F2D671FF0B4 for ; Tue, 10 Nov 2026 11:58:48 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 9871321428; Tue, 10 Nov 2026 11:58:48 +0100 (CET) Date: Tue, 10 Nov 2026 11:58:39 +0100 From: Gabriel Goller To: Christoph Heiss Subject: Re: [PATCH proxmox v2 2/3] fix #6121: network-api: config: add support for `bond-miimon` option Message-ID: References: <20261109143117.778971-1-c.heiss@proxmox.com> <20261109143117.778971-3-c.heiss@proxmox.com> <7eef50e6-66b2-4eba-8a3c-410f308aa963@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7eef50e6-66b2-4eba-8a3c-410f308aa963@proxmox.com> User-Agent: NeoMutt/20260504 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794308325770 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.231 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6OBY2DVUKL37APHY7PY6BG2MQH3VZF22 X-Message-ID-Hash: 6OBY2DVUKL37APHY7PY6BG2MQH3VZF22 X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pbs-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 10.11.2026 11:13, Christoph Heiss wrote: > Thanks for taking a look! > > On 11/9/26 15:57, Gabriel Goller wrote: > > On 09.11.2026 15:28, Christoph Heiss wrote: > >> Fixes #6121 [0]. > >> > >> Adds support for the 'bond-miimon' option to the ifupdown(2) config > >> writer and parser. > >> > >> The option is always written out for bonds, with a default value of 100 > >> - much like PVE does it. > > > > Umm I understand this but what about the bond-arp-interval (arp-mode). These > > properties are mutually exclusive... > > Interesting note. AFAICS we don't allow configuring that property > through our stack anywhere yet, i.e. neither PVE nor PBS/PDM (didn't > look at PMG specifically, but I assume it's the same there). Hmm yeah thats a reason for leaving it out... > > Maybe we should allow the user to configure arp mode as well? > > We could possibly implement that separately in the future, if arp-mode > is something regularly needed/set by users. But this is rather > tangentially to this series IMO. Haven't looked at the code, if this is something that can be added easily then it's fine with me. I think the arp mode is used quite seldomly anyway.. Maybe @Stefan can add something here?