From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 47C4F1FF16F for ; Tue, 16 Sep 2025 10:13:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 66F79D20E; Tue, 16 Sep 2025 10:13:22 +0200 (CEST) Message-ID: Date: Tue, 16 Sep 2025 10:13:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Thomas Lamprecht , Proxmox Backup Server development discussion References: <20250828102604.463662-1-c.ebner@proxmox.com> <20250828102604.463662-2-c.ebner@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1758010392691 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.043 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lib.rs] Subject: Re: [pbs-devel] [PATCH proxmox 1/2] http: factor out PBS shared rate limiter implementation X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 9/15/25 9:10 PM, Thomas Lamprecht wrote: > Am 28.08.25 um 12:26 schrieb Christian Ebner: >> Moves the current shared rate limiter implementation from the Proxmox >> Backup Server into proxmox-http for it to be reusable, e.g. for s3 >> client rate limiting. > > Two things: > 1. There is still the PROXMOX_BACKUP_SHARED_RATE_LIMITER_MAGIC_1_0 references > to PBS that should be made generic in naming, otherwise it might be confusing. Okay, as mentioned in the note to the patch I was a bit unsure if this could cause some backwards compatibility issues, so I did not adapt it. But as discussed off-list, will adapt the constant name and note this in the comment to avoid future confusion on why this value was generated as is. > 2. Should the this and the existing RateLimiter go into their own crate? They > are not really tied to being used with HTTP after all, token bucket filter > are a rather generic concept and besides the central module entry point lib.rs > you do not touch any file from the crate here. What do you think? Yes, will see to move this to a dedicated crate then. Thanks a lot for feedback! _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel