From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8E4FC7185A for ; Thu, 20 May 2021 08:54:17 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 84C5921D3C for ; Thu, 20 May 2021 08:54:17 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 5D26B21D23 for ; Thu, 20 May 2021 08:54:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2F227429A7 for ; Thu, 20 May 2021 08:54:16 +0200 (CEST) To: Proxmox Backup Server development discussion References: <20210514125923.14955-1-d.csapak@proxmox.com> <20210514125923.14955-5-d.csapak@proxmox.com> <2e2480a1-1c71-2a53-6a38-1b7a39c17a02@proxmox.com> <487fd2f2-802b-2b59-0544-1ecc10c40353@proxmox.com> From: Dominik Csapak Message-ID: Date: Thu, 20 May 2021 08:54:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <487fd2f2-802b-2b59-0544-1ecc10c40353@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup v2 4/5] ui: tape/window/TapeRestore: enabling selecting multiple snapshots X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 May 2021 06:54:17 -0000 On 5/18/21 7:00 PM, Thomas Lamprecht wrote: > On 18.05.21 09:00, Thomas Lamprecht wrote: >> On 14.05.21 14:59, Dominik Csapak wrote: >>> by including the new snapshotselector. If a whole media-set is to be >>> restored, select all snapshots >>> >>> to achieve this, we drop the 'restoreid' and 'datastores' properties >>> for the restore window, and replace them by a 'prefilter' object >>> (with 'store' and 'snapshot' properties) >>> >>> to be able to show the snapshots, we now have to always load the >>> content of that media-set, so drop the short-circuit if we have >>> the datastores already. >>> >>> also to improve space-usage, shift the datastores mapping grid in the >>> right column, and all non datastore related options in the left one, >>> showing the snapshot grid below >>> (the datastore mapping is now limited to 150px; ~3 datastores, and scrollable) >>> >>> Signed-off-by: Dominik Csapak >>> --- >>> www/tape/BackupOverview.js | 27 +++------- >>> www/tape/window/TapeRestore.js | 99 ++++++++++++++++++---------------- >>> 2 files changed, 61 insertions(+), 65 deletions(-) >>> >> > > Oh, and before I forget it, it irked me a bit that the content tree's expansion > state was not restored after the store reloaded triggered due to the restore > edit-window getting closed, all just got collapsed again. > Maybe you can improve that? I'm not even sure that a reload is useful after the > close, as any tape-restore itself did not alter the content there. > yes you're right, restore should not trigger a reload as for keeping the expanded state on a reload, i'll have to check how much work that is. it's a bit different than e.g. the datastore content, since we here have separate api calls for the first and subsequent levels, so to check for differences gets a bit more complicated and possibly more expensive in terms of api calls