From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 91E9072DFD for ; Mon, 5 Jul 2021 08:33:13 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 85BC01B1DF for ; Mon, 5 Jul 2021 08:33:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id ED1731B1CF for ; Mon, 5 Jul 2021 08:33:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B101640A69 for ; Mon, 5 Jul 2021 08:33:11 +0200 (CEST) Message-ID: Date: Mon, 5 Jul 2021 08:32:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Stoiko Ivanov References: <20210628184109.110296-1-s.ivanov@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210628184109.110296-1-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.532 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied-series: [PATCH proxmox-backup v2 0/3] acme: add sleep for dns record propagation X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jul 2021 06:33:13 -0000 On 28.06.21 20:41, Stoiko Ivanov wrote: > changes v1 -> v2 (based on Thomas' feedback - huge thx!): > * moved the sleep to only run for setup not for teardown > * added a check to only sleep and print the message if the delay is > 0 > for consistency, and to be able to skip it (e.g. for a simple > powerdns-setup) > * while looking through the code found a small glitch in an error > message (the fix is in patch 1/3) > > forgot to mention that the patches were developed and tested on top of > the current stable-1 branch (they apply cleanly on master, but I did not > explicitly test on master) > > cover-letter for v1: > The issue was brought up in our community forum: > https://forum.proxmox.com/threads/acme-configuration-via-gui.91381/ > > While I could not directly reproduce it (writing to a pdns-database is > faster than waiting on cloud-flare to propagate their records) I > compared the task-log to the one from PMG. > > The use of tokio::time::sleep was taken from the other delays in > api2::node::certificate, for the rest I mostly trusted the compiler > warnings and rustfmt. > > > Stoiko Ivanov (3): > acme: plugin: fix error message > config: acme: make validation_delay crate public > fix #3496: acme: plugin: add sleep for dns propagation > > src/acme/plugin.rs | 19 +++++++++++++++++-- > src/config/acme/plugin.rs | 2 +- > 2 files changed, 18 insertions(+), 3 deletions(-) > applied series, thanks!