From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D8D9E722DE for ; Tue, 25 May 2021 07:53:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CBE6F28630 for ; Tue, 25 May 2021 07:53:00 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id CD1BC28621 for ; Tue, 25 May 2021 07:52:59 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9CF3543E47 for ; Tue, 25 May 2021 07:52:59 +0200 (CEST) Message-ID: Date: Tue, 25 May 2021 07:52:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101 Thunderbird/89.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Dominik Csapak References: <20210512144232.5643-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210512144232.5643-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied: [PATCH proxmox-backup] ui: add node options under 'Configuration -> Options' X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 May 2021 05:53:00 -0000 On 12.05.21 16:42, Dominik Csapak wrote: > for now only http-proxy lives there, but we will add more options later, > such as > * email from > * default gui language > > Signed-off-by: Dominik Csapak > --- > www/Makefile | 1 + > www/SystemConfiguration.js | 5 +++++ > www/config/NodeOptionView.js | 42 ++++++++++++++++++++++++++++++++++++ > 3 files changed, 48 insertions(+) > create mode 100644 www/config/NodeOptionView.js > > applied, thanks! But reworked it to a more static declaration in and avoided introducing the slightly weird, over-general `Configuration -> Options` tab, I just added it to the existing `Authentication` one for now, fits there OK enough and solving the Configuration/Administration weirdness needs more thought and a major release, as I'd like to avoid reshuffling components in a stable one.