From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E8E801FF164 for ; Fri, 22 Nov 2024 11:12:21 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 44D85F66C; Fri, 22 Nov 2024 11:12:30 +0100 (CET) Message-ID: Date: Fri, 22 Nov 2024 11:11:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= , pbs-devel@lists.proxmox.com References: <20241121154337.471425-1-c.ebner@proxmox.com> <20241121154337.471425-4-c.ebner@proxmox.com> <173226608868.2118190.15465009393024345476@yuna.proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <173226608868.2118190.15465009393024345476@yuna.proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 3/4] server: push: add error context to all target api calls X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" T24gMTEvMjIvMjQgMTA6MDEsIEZhYmlhbiBHcsO8bmJpY2hsZXIgd3JvdGU6Cj4gUXVvdGluZyBD aHJpc3RpYW4gRWJuZXIgKDIwMjQtMTEtMjEgMTY6NDM6MzYpCj4+IE1ha2UgaXQgY2xlYXIgZnJv bSB0aGUgY29udGV4dCB0aGF0IHRoZXNlIGVycm9yIG1lc3NhZ2VzIHN0ZW0gZnJvbQo+PiB0aGUg cmVzcG9uc2Ugb2YgYW4gYXBpIGNhbGwgcmF0aGVyIHRoYW4gYSBsb2NhbCBlcnJvci4KPj4KPj4g U2lnbmVkLW9mZi1ieTogQ2hyaXN0aWFuIEVibmVyIDxjLmVibmVyQHByb3htb3guY29tPgo+PiAt LS0KPj4gICBzcmMvc2VydmVyL3B1c2gucnMgfCAyNCArKysrKysrKysrKysrKysrKy0tLS0tLS0K Pj4gICAxIGZpbGUgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKPj4K Pj4gZGlmZiAtLWdpdCBhL3NyYy9zZXJ2ZXIvcHVzaC5ycyBiL3NyYy9zZXJ2ZXIvcHVzaC5ycwo+ PiBpbmRleCA4NmNlZjU1MjAuLmZlMmUxMTIyMCAxMDA2NDQKPj4gLS0tIGEvc3JjL3NlcnZlci9w dXNoLnJzCj4+ICsrKyBiL3NyYy9zZXJ2ZXIvcHVzaC5ycwo+PiBAQCAtMjE5LDcgKzIxOSw5IEBA IGFzeW5jIGZuIHJlbW92ZV90YXJnZXRfbmFtZXNwYWNlKAo+PiAgICAgICBpZiBwYXJhbXMudGFy Z2V0LnN1cHBvcnRzX3BydW5lX2RlbGV0ZV9zdGF0cyB7Cj4+ICAgICAgICAgICBsZXQgZGF0YSA9 IHJlc3VsdFsiZGF0YSJdLnRha2UoKTsKPj4gICAgICAgICAgIHNlcmRlX2pzb246OmZyb21fdmFs dWUoZGF0YSkubWFwX2Vycih8ZXJyfCB7Cj4+IC0gICAgICAgICAgICBmb3JtYXRfZXJyISgicmVt b3ZpbmcgdGFyZ2V0IG5hbWVzcGFjZSB7dGFyZ2V0X25hbWVzcGFjZX0gZmFpbGVkIC0ge2Vycn0i KQo+PiArICAgICAgICAgICAgZm9ybWF0X2VyciEoCj4+ICsgICAgICAgICAgICAgICAgIkZhaWxl ZCB0byByZW1vdmUgcmVtb3RlIG5hbWVzcGFjZSB7dGFyZ2V0X25hbWVzcGFjZX0sIHJlbW90ZSBy ZXR1cm5lZDoge2Vycn0iCj4+ICsgICAgICAgICAgICApCj4gCj4gdGhpcyBpcyBhdHRhY2hlZCB0 byB0aGUgd3JvbmcgZXJyb3IgLSBpdCBzaG91bGQgYmUgYXR0YWNoZWQgdG8gdGhlIGNsaWVudC5k ZWxldGUgY2FsbCByaWdodCBhYm92ZS4uCgpPb2YsIGNvcnJlY3QsIHdpbGwgZml4IHRoYXQuIFRo YW5rcyBmb3IgY2F0Y2hpbmcgdGhpcyEKCj4gCj4gdGhpcyBoZXJlIHNob3VsZCBpbnN0ZWFkIGFk ZCB0aGUgY29udGV4dCB0aGF0IHdlIGZhaWxlZCB0byBwYXJzZSB0aGUgcmV0dXJuZWQKPiB2YWx1 ZSAod2hpY2ggc2hvdWxkIG5ldmVyIGhhcHBlbiwgdGhhdCBtZWFucyB3ZSBtaXNzZWQgc29tZSBB UEkgYnJlYWthZ2UuLikKPiAKPj4gICAgICAgICAgIH0pCj4+ICAgICAgIH0gZWxzZSB7Cj4+ICAg ICAgICAgICBPayhCYWNrdXBHcm91cERlbGV0ZVN0YXRzOjpkZWZhdWx0KCkpCj4+IEBAIC0yMzYs NyArMjM4LDggQEAgYXN5bmMgZm4gZmV0Y2hfdGFyZ2V0X2dyb3VwcygKPj4gICAgICAgbGV0IGFy Z3MgPSBTb21lKHNlcmRlX2pzb246Ompzb24hKHsgIm5zIjogdGFyZ2V0X25hbWVzcGFjZS5uYW1l KCkgfSkpOwo+PiAgIAo+PiAgICAgICBsZXQgbXV0IHJlc3VsdCA9IHBhcmFtcy50YXJnZXQuY2xp ZW50LmdldCgmYXBpX3BhdGgsIGFyZ3MpLmF3YWl0PzsKPj4gLSAgICBsZXQgZ3JvdXBzOiBWZWM8 R3JvdXBMaXN0SXRlbT4gPSBzZXJkZV9qc29uOjpmcm9tX3ZhbHVlKHJlc3VsdFsiZGF0YSJdLnRh a2UoKSk/Owo+PiArICAgIGxldCBncm91cHM6IFZlYzxHcm91cExpc3RJdGVtPiA9IHNlcmRlX2pz b246OmZyb21fdmFsdWUocmVzdWx0WyJkYXRhIl0udGFrZSgpKQo+PiArICAgICAgICAubWFwX2Vy cih8ZXJyfCBmb3JtYXRfZXJyISgiRmFpbGVkIHRvIGZldGNoIHJlbW90ZSBncm91cHMsIHJlbW90 ZSByZXR1cm5lZDoge2Vycn0iKSk/Owo+IAo+IHNhbWUgaGVyZSwganVzdCB3aXRoIGdldCBpbnN0 ZWFkIG9mIGRlbGV0ZSA7KQo+IAo+PiAgIAo+PiAgICAgICBsZXQgKG11dCBvd25lZCwgbm90X293 bmVkKSA9IGdyb3Vwcy5pbnRvX2l0ZXIoKS5mb2xkKAo+PiAgICAgICAgICAgKFZlYzo6bmV3KCks IEhhc2hTZXQ6Om5ldygpKSwKPj4gQEAgLTI3Nyw4ICsyODAsOSBAQCBhc3luYyBmbiByZW1vdmVf dGFyZ2V0X2dyb3VwKAo+PiAgIAo+PiAgICAgICBpZiBwYXJhbXMudGFyZ2V0LnN1cHBvcnRzX3By dW5lX2RlbGV0ZV9zdGF0cyB7Cj4+ICAgICAgICAgICBsZXQgZGF0YSA9IHJlc3VsdFsiZGF0YSJd LnRha2UoKTsKPj4gLSAgICAgICAgc2VyZGVfanNvbjo6ZnJvbV92YWx1ZShkYXRhKQo+PiAtICAg ICAgICAgICAgLm1hcF9lcnIofGVycnwgZm9ybWF0X2VyciEoInJlbW92aW5nIHRhcmdldCBncm91 cCB7YmFja3VwX2dyb3VwfSBmYWlsZWQgLSB7ZXJyfSIpKQo+PiArICAgICAgICBzZXJkZV9qc29u Ojpmcm9tX3ZhbHVlKGRhdGEpLm1hcF9lcnIofGVycnwgewo+PiArICAgICAgICAgICAgZm9ybWF0 X2VyciEoIkZhaWxlZCB0byByZW1vdmUgcmVtb3RlIGdyb3VwIHtiYWNrdXBfZ3JvdXB9LCByZW1v dGUgcmV0dXJuZWQ6IHtlcnJ9IikKPj4gKyAgICAgICAgfSkKPiAKPiBoZXJlIGFzIHdlbGwKPiAK Pj4gICAgICAgfSBlbHNlIHsKPj4gICAgICAgICAgIE9rKEJhY2t1cEdyb3VwRGVsZXRlU3RhdHM6 OmRlZmF1bHQoKSkKPj4gICAgICAgfQo+PiBAQCAtMzEzLDcgKzMxNyw3IEBAIGFzeW5jIGZuIGNo ZWNrX29yX2NyZWF0ZV90YXJnZXRfbmFtZXNwYWNlKAo+PiAgICAgICAgICAgICAgIG1hdGNoIHBh cmFtcy50YXJnZXQuY2xpZW50LnBvc3QoJmFwaV9wYXRoLCBTb21lKGFyZ3MpKS5hd2FpdCB7Cj4+ ICAgICAgICAgICAgICAgICAgIE9rKF8pID0+IGluZm8hKCJTdWNjZXNzZnVsbHkgY3JlYXRlZCBu ZXcgbmFtZXNwYWNlIHtjdXJyZW50fSBvbiByZW1vdGUiKSwKPj4gICAgICAgICAgICAgICAgICAg RXJyKGVycikgPT4gewo+PiAtICAgICAgICAgICAgICAgICAgICBiYWlsISgiUmVtb3RlIGNyZWF0 aW9uIG9mIG5hbWVzcGFjZSB7Y3VycmVudH0gZmFpbGVkLCByZW1vdGUgcmV0dXJuZWQ6IHtlcnJ9 IikKPj4gKyAgICAgICAgICAgICAgICAgICAgYmFpbCEoIkNyZWF0aW9uIG9mIHJlbW90ZSBuYW1l c3BhY2Uge2N1cnJlbnR9IGZhaWxlZCwgcmVtb3RlIHJldHVybmVkOiB7ZXJyfSIpCj4+ICAgICAg ICAgICAgICAgICAgIH0KPj4gICAgICAgICAgICAgICB9Cj4+ICAgICAgICAgICAgICAgZXhpc3Rp bmdfdGFyZ2V0X25hbWVzcGFjZXMucHVzaChjdXJyZW50LmNsb25lKCkpOwo+PiBAQCAtNTg1LDcg KzU4OSw4IEBAIGFzeW5jIGZuIGZldGNoX3RhcmdldF9zbmFwc2hvdHMoCj4+ICAgICAgICAgICBh cmdzWyJucyJdID0gc2VyZGVfanNvbjo6dG9fdmFsdWUodGFyZ2V0X25hbWVzcGFjZSk/Owo+PiAg ICAgICB9Cj4+ICAgICAgIGxldCBtdXQgcmVzdWx0ID0gcGFyYW1zLnRhcmdldC5jbGllbnQuZ2V0 KCZhcGlfcGF0aCwgU29tZShhcmdzKSkuYXdhaXQ/Owo+PiAtICAgIGxldCBzbmFwc2hvdHM6IFZl YzxTbmFwc2hvdExpc3RJdGVtPiA9IHNlcmRlX2pzb246OmZyb21fdmFsdWUocmVzdWx0WyJkYXRh Il0udGFrZSgpKT87Cj4+ICsgICAgbGV0IHNuYXBzaG90czogVmVjPFNuYXBzaG90TGlzdEl0ZW0+ ID0gc2VyZGVfanNvbjo6ZnJvbV92YWx1ZShyZXN1bHRbImRhdGEiXS50YWtlKCkpCj4+ICsgICAg ICAgIC5tYXBfZXJyKHxlcnJ8IGZvcm1hdF9lcnIhKCJGYWlsZWQgdG8gZmV0Y2ggcmVtb3RlIHNu YXBzaG90cywgcmVtb3RlIHJldHVybmVkOiB7ZXJyfSIpKT87Cj4gCj4gaGVyZSBhcyB3ZWxsCj4g Cj4+ICAgCj4+ICAgICAgIE9rKHNuYXBzaG90cykKPj4gICB9Cj4+IEBAIC02MDMsNyArNjA4LDEy IEBAIGFzeW5jIGZuIGZvcmdldF90YXJnZXRfc25hcHNob3QoCj4+ICAgICAgIGlmICF0YXJnZXRf bmFtZXNwYWNlLmlzX3Jvb3QoKSB7Cj4+ICAgICAgICAgICBhcmdzWyJucyJdID0gc2VyZGVfanNv bjo6dG9fdmFsdWUodGFyZ2V0X25hbWVzcGFjZSk/Owo+PiAgICAgICB9Cj4+IC0gICAgcGFyYW1z LnRhcmdldC5jbGllbnQuZGVsZXRlKCZhcGlfcGF0aCwgU29tZShhcmdzKSkuYXdhaXQ/Owo+PiAr ICAgIHBhcmFtcwo+PiArICAgICAgICAudGFyZ2V0Cj4+ICsgICAgICAgIC5jbGllbnQKPj4gKyAg ICAgICAgLmRlbGV0ZSgmYXBpX3BhdGgsIFNvbWUoYXJncykpCj4+ICsgICAgICAgIC5hd2FpdAo+ PiArICAgICAgICAubWFwX2Vycih8ZXJyfCBmb3JtYXRfZXJyISgiRmFpbGVkIHRvIHJlbW92ZSBy ZW1vdGUgc25hcHNob3QsIHJlbW90ZSByZXR1cm5lZDoge2Vycn0iKSk/Owo+IAo+IHRoaXMgc2hv dWxkIHByb2JhYmx5IGJlIGp1c3QgIlJlcXVlc3QgdG8gcmVtb3RlIHJldHVybmVkIHtlcnJ9Iiwg c2luY2UgdGhlIGNhbGwKPiBzaXRlIGFscmVhZHkgbG9ncyB0aGUgc25hcHNob3QgbmFtZSBhbmQg dGhlIGZhY3QgdGhhdCB0aGlzIGlzIHJlbW92YWwgZmFpbGluZwo+IDspCj4gCj4+ICAgCj4+ICAg ICAgIE9rKCgpKQo+PiAgIH0KPj4gLS0gCj4+IDIuMzkuNQo+Pgo+Pgo+Pgo+PiBfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+PiBwYnMtZGV2ZWwgbWFpbGlu ZyBsaXN0Cj4+IHBicy1kZXZlbEBsaXN0cy5wcm94bW94LmNvbQo+PiBodHRwczovL2xpc3RzLnBy b3htb3guY29tL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9wYnMtZGV2ZWwKPj4KPj4KCgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KcGJzLWRldmVsIG1h aWxpbmcgbGlzdApwYnMtZGV2ZWxAbGlzdHMucHJveG1veC5jb20KaHR0cHM6Ly9saXN0cy5wcm94 bW94LmNvbS9jZ2ktYmluL21haWxtYW4vbGlzdGluZm8vcGJzLWRldmVsCg==