From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 8B9E11FF13F for ; Thu, 07 May 2026 10:42:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DD1DFF96D; Thu, 7 May 2026 10:42:30 +0200 (CEST) Message-ID: Date: Thu, 7 May 2026 10:42:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 proxmox-backup 3/3] client: pxar: skip files on fstatat permission errors To: Robert Obkircher , pbs-devel@lists.proxmox.com References: <20260506115016.171006-1-r.obkircher@proxmox.com> <20260506115016.171006-4-r.obkircher@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20260506115016.171006-4-r.obkircher@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778143236540 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.070 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com,create.rs] Message-ID-Hash: UIEG6KO6JYLLEOWNYMUPTZPOIC3YRE57 X-Message-ID-Hash: UIEG6KO6JYLLEOWNYMUPTZPOIC3YRE57 X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 5/6/26 1:49 PM, Robert Obkircher wrote: > Log a warning instead of aborting the entire backup if fstatat returns > a permission error. This is preferable when running backups without > full knowledge or control over the contents [1]. It is also more > consistent with how we treat EACCES when opening files. > > Note that it was already possible to explicitly exclude such files[2]. > > [1] https://forum.proxmox.com/threads/bug-with-fuse-mounts.182315/ nit: can be more concise by using thread id only https://forum.proxmox.com/threads/182315/ > [2] https://bugzilla.proxmox.com/show_bug.cgi?id=4380 > > Signed-off-by: Robert Obkircher > --- > pbs-client/src/pxar/create.rs | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/pbs-client/src/pxar/create.rs b/pbs-client/src/pxar/create.rs > index 47cbf50a8..c101415c1 100644 > --- a/pbs-client/src/pxar/create.rs > +++ b/pbs-client/src/pxar/create.rs > @@ -710,6 +710,11 @@ impl Archiver { > warn!("warning: file vanished while reading directory: {full_path:?}"); > continue; > } > + Err(Errno::EACCES) => { > + // may happen for fuse mountpoints without allow_other or allow_root > + warn!("failed to stat file: {full_path:?}: access denied"); nit: similar to comment on previous patch, this should combine the warning into a report_file_access_denied() or similar. > + continue; > + } > Err(Errno::ESTALE) => { > self.report_stale_file_handle(Some(&full_path)); > continue;