From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B2D4F1FF137 for ; Tue, 31 Mar 2026 11:11:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 105F01539C; Tue, 31 Mar 2026 11:11:28 +0200 (CEST) Message-ID: Date: Tue, 31 Mar 2026 11:10:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox v6 08/12] s3-client: api-types: define request counter thresholds To: Christian Ebner , pbs-devel@lists.proxmox.com References: <20260319094100.240765-1-c.ebner@proxmox.com> <20260319094100.240765-9-c.ebner@proxmox.com> Content-Language: en-US From: Hannes Laimer In-Reply-To: <20260319094100.240765-9-c.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774948199491 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.081 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: SXNQTLCP4HYOTTNDQIV33S4IAE53HNBX X-Message-ID-Hash: SXNQTLCP4HYOTTNDQIV33S4IAE53HNBX X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: nit inline On 2026-03-19 10:41, Christian Ebner wrote: > These will be used in the datastore config as property string to > allow setting per-request/traffic volume notification thresholds. > > Signed-off-by: Christian Ebner > --- > proxmox-s3-client/src/api_types.rs | 59 ++++++++++++++++++++++++++++++ > 1 file changed, 59 insertions(+) > > diff --git a/proxmox-s3-client/src/api_types.rs b/proxmox-s3-client/src/api_types.rs > index b4fc24e0..0900c2b2 100644 > --- a/proxmox-s3-client/src/api_types.rs > +++ b/proxmox-s3-client/src/api_types.rs > @@ -257,3 +257,62 @@ pub struct S3BucketListItem { > /// S3 bucket name. > pub name: String, > } > + > +#[api( > + properties: { > + "s3-get": { > + type: Integer, > + optional: true, > + }, > + "s3-put": { > + type: Integer, > + optional: true, > + }, > + "s3-post": { > + type: Integer, > + optional: true, > + }, > + "s3-head": { > + type: Integer, > + optional: true, > + }, > + "s3-delete": { > + type: Integer, > + optional: true, > + }, > + "s3-upload": { > + type: HumanByte, > + optional: true, > + }, > + "s3-download": { > + type: HumanByte, > + optional: true, > + } > + }, > +)] > +#[derive(Default, Deserialize, Serialize)] > +#[serde(rename_all = "kebab-case")] > +/// Request counter thresholds > +pub struct RequestCounterThresholds { > + #[serde(skip_serializing_if = "Option::is_none")] > + /// Threshold for GET requests. > + pub s3_get: Option, > + #[serde(skip_serializing_if = "Option::is_none")] > + /// Threshold for PUT requests. > + pub s3_put: Option, > + #[serde(skip_serializing_if = "Option::is_none")] > + /// Threshold for POST requests. > + pub s3_post: Option, > + #[serde(skip_serializing_if = "Option::is_none")] > + /// Threshold for HEAD requests. > + pub s3_head: Option, > + #[serde(skip_serializing_if = "Option::is_none")] > + /// Threshold for DELETE requests. > + pub s3_delete: Option, > + #[serde(skip_serializing_if = "Option::is_none")] > + /// Threshold for download traffic to datastore's backing S3 bucket. these .. > + pub s3_upload: Option, > + #[serde(skip_serializing_if = "Option::is_none")] > + /// Threshold for upload traffic to datastore's backing S3 bucket. .. two, are swapped > + pub s3_download: Option, > +}