From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 27F1CB417 for ; Mon, 11 Sep 2023 08:56:51 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0A8A64AAB for ; Mon, 11 Sep 2023 08:56:21 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 11 Sep 2023 08:56:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 27C82441D8 for ; Mon, 11 Sep 2023 08:56:19 +0200 (CEST) Message-ID: Date: Mon, 11 Sep 2023 08:56:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: pbs-devel@lists.proxmox.com References: <20230908133219.247294-1-g.goller@proxmox.com> From: Maximiliano Sandoval In-Reply-To: <20230908133219.247294-1-g.goller@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup v3] fix #4343: updated `view_task_result` to bail on task failure X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Sep 2023 06:56:51 -0000 On 9/8/23 15:32, Gabriel Goller wrote: > Now we make an additional request on `api2/json/.../tasks/{upid}/status` to > get the `exitstatus` of the task. This allows us to `bail` and thus > get a non-zero exit code in the cli. > > Signed-off-by: Gabriel Goller > --- > > changes v2: > - removed unrelated cleanup > > changes v1: > - check on each iteration if the task is finished, then bubble up the > original error of the task. This was inpractical though, so we print > the error and return a generic error. > > pbs-client/src/task_log.rs | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/pbs-client/src/task_log.rs b/pbs-client/src/task_log.rs > index 0bbb928d..709d0d08 100644 > --- a/pbs-client/src/task_log.rs > +++ b/pbs-client/src/task_log.rs > @@ -96,6 +96,14 @@ pub async fn display_task_log( > } > } > > + let status_path = format!("api2/json/nodes/localhost/tasks/{upid_encoded}/status"); > + let status_result = client.get(&status_path, None).await?; > + if status_result["data"]["status"].as_str() == Some("stopped") > + && status_result["data"]["exitstatus"].as_str() != Some("OK") > + { > + bail!("task failed"); The info about the exit status is not propagated, maybe one could display it too? > + } > + > Ok(()) > }; >