From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 36C01FE84 for ; Tue, 25 Jul 2023 10:56:30 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 17BE7181A6 for ; Tue, 25 Jul 2023 10:56:30 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 25 Jul 2023 10:56:29 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 25E5843FA0 for ; Tue, 25 Jul 2023 10:56:29 +0200 (CEST) Message-ID: Date: Tue, 25 Jul 2023 10:56:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: de-AT, en-US To: Proxmox Backup Server development discussion , Stefan Sterz References: <20230721143403.1288116-1-s.sterz@proxmox.com> <20230721143403.1288116-2-s.sterz@proxmox.com> From: Lukas Wagner In-Reply-To: <20230721143403.1288116-2-s.sterz@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.064 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [ietf.org] Subject: Re: [pbs-devel] [PATCH proxmox 2/2] ldap: only search base of base_dn when checking connection X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jul 2023 08:56:30 -0000 Looks good to me! (also applies to the new integration tests) Tested-by: Lukas Wagner Reviewed-by: Lukas Wagner On 7/21/23 16:34, Stefan Sterz wrote: > * when using an anonymous bind with slapd in its default configuration > the default size limit will also be enforced against a paged > search. this means that while a configuration may succeed with 5 > users with an anonymous bind, it will fail with 500+ users. > * if the client specifies a size limit for the search and the server > finds more results than specified by the search limit it will > return only the specified amount of results. however, the result > code will still be 4 (sizeLimitExceeded) resulting in an error. the > same happens if the server specifies a limit and the search exceeds > it. it also uses the the result code 4 (sizeLimitExceeded) in that > case. > * if a streaming_search is finished before all results are retrieved, > ldap3 will handle this as specified in the relevant rfc from what i > can tell [1]. however, the result code will then be 88 for a user > canceled request, which is treated as an `Err` Result in ldap3. > > [1]: https://datatracker.ietf.org/doc/html/rfc2696 -- - Lukas