From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 984F01FF185 for ; Mon, 21 Jul 2025 22:13:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 35ADC1998F; Mon, 21 Jul 2025 22:14:12 +0200 (CEST) Message-ID: Date: Mon, 21 Jul 2025 22:14:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox Backup Server development discussion , Christian Ebner References: <20250721164507.1045869-1-c.ebner@proxmox.com> <20250721164507.1045869-28-c.ebner@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20250721164507.1045869-28-c.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753128841619 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup v10 24/46] ui: add s3 client edit window for configuration create/edit X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Am 21.07.25 um 18:45 schrieb Christian Ebner: > Adds an edit window for creating or editing S3 client configurations. > Loosely based on the same edit window for the remote configuration. > > Signed-off-by: Christian Ebner > --- > changes since version 9: > - no changes > > www/window/S3ClientEdit.js | 148 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 148 insertions(+) > create mode 100644 www/window/S3ClientEdit.js > > diff --git a/www/window/S3ClientEdit.js b/www/window/S3ClientEdit.js > new file mode 100644 > index 000000000..b22e920f8 > --- /dev/null > +++ b/www/window/S3ClientEdit.js > @@ -0,0 +1,148 @@ --8<-- snip -->8-- > + getValues: function () { > + let me = this; > + let values = me.callParent(arguments); > + > + if (me.isCreate) { > + /// Secrets are stored into separate config, but set the same id for both configs > + values['secrets-id'] = values.id; > + } The whole if above can be now dropped, one will actually get an error otherwise when creating a new S3 client on the web UI. I can squash that in on applying if nothing else comes up. > + > + if (values.delete && !Ext.isArray(values.delete)) { > + values.delete = values.delete.split(','); > + } > + PBS.Utils.delete_if_default(values, 'path-style', false, me.isCreate); > + > + if (values['access-key'] === '') { > + delete values['access-key']; > + } > + > + if (values['secret-key'] === '') { > + delete values['secret-key']; > + } > + > + return values; > + }, > +}); _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel