From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 16FC990A48 for ; Thu, 25 Jan 2024 12:50:03 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id ED0E118537 for ; Thu, 25 Jan 2024 12:49:32 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 25 Jan 2024 12:49:31 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9117249290 for ; Thu, 25 Jan 2024 12:49:31 +0100 (CET) Message-ID: Date: Thu, 25 Jan 2024 12:49:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Gabriel Goller To: Thomas Lamprecht , Proxmox Backup Server development discussion , Fiona Ebner Reply-To: Proxmox Backup Server development discussion References: <20240124103459.74843-1-g.goller@proxmox.com> <79baa37c-654f-4b34-a5e9-ce5c64355433@proxmox.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.131 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup] api: make prune-group a real workertask X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jan 2024 11:50:03 -0000 Sent a v2! On 24-01-2024 14:42, Gabriel Goller wrote: > On 24-01-2024 14:28, Thomas Lamprecht wrote: >> Am 24/01/2024 um 14:17 schrieb Fiona Ebner: >>> Am 24.01.24 um 11:34 schrieb Gabriel Goller: >>>> - Ok(json!(prune_result)) >>>> +    Ok(json!(upid)) >>> That seems like a breaking API change at a first glance and thus has to >>> wait for the next major release unfortunately. >>> >>> AFAIU the same rules as for PVE apply, see: >>> https://pve.proxmox.com/wiki/Proxmox_VE_API#API_Stability_.26_Breakage >>> >> Yes, if applied strictly, and this here might be indeed a breakage that >> matters in practice. >> >> But you can work around that by making it use a worker task opt-in via >> a new parameter boolean flag. > Will do that. >> Oh, and isn't prune_result now unused? We're still lacking a simple >> and standardized method to save a structured result alongside a task >> UPID, otherwise it could be saved there, but that's another topic. > Hmm, yeah noticed that... I think I'll convert it to a structure and > pretty-print it to the task-log. > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > >