From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 43A50F7DB for ; Fri, 29 Sep 2023 15:38:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2B5942477 for ; Fri, 29 Sep 2023 15:38:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 29 Sep 2023 15:38:18 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9C9F0480F8 for ; Fri, 29 Sep 2023 15:38:18 +0200 (CEST) Message-ID: Date: Fri, 29 Sep 2023 15:38:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: de-AT, en-US To: Proxmox Backup Server development discussion , Filip Schauer , Wolfgang Bumiller References: <20230922124111.121415-1-f.schauer@proxmox.com> <7qha55edsqqk6gy7etu7agyeh5itze2i6ocvbc6vp2n3dstgqt@g4a4m36mq5l7> <3bf667ac-ab0a-dc60-214e-a185052598bf@proxmox.com> From: Lukas Wagner In-Reply-To: <3bf667ac-ab0a-dc60-214e-a185052598bf@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH vma-to-pbs] Initial commit X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Sep 2023 13:38:50 -0000 On 9/29/23 15:22, Filip Schauer wrote: >>> --- /dev/null >>> +++ b/.gitmodules >>> @@ -0,0 +1,6 @@ >>> +[submodule "submodules/proxmox-backup-qemu"] >>> +    path = submodules/proxmox-backup-qemu >>> +    url = git://git.proxmox.com/git/proxmox-backup-qemu.git >>> +[submodule "submodules/proxmox"] >>> +    path = submodules/proxmox >>> +    url = git://git.proxmox.com/git/proxmox.git >> ^ We don't need proxmox.git as submodule. > We use proxmox_sys::linux::tty::read_password. I believe what Wolfgang meant was that you do not to need to add proxmox.git as a submodule. Since you patch crate.io with the local registry at /usr/share/cargo, you can just install the dependencies that you need via apt and use them just as any other dep inside your Cargo.toml file. Since you need `proxmox-sys`, the required package would be `librust-proxmox-sys-dev`. The newest packaged version is 0.5.0-1, so you'd need to add proxmox-sys = "0.5.0" to your Cargo.toml file. -- - Lukas