From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <d.csapak@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 7DC099EC72
for <pbs-devel@lists.proxmox.com>; Tue, 28 Nov 2023 14:50:29 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 651EF17C6B
for <pbs-devel@lists.proxmox.com>; Tue, 28 Nov 2023 14:49:59 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pbs-devel@lists.proxmox.com>; Tue, 28 Nov 2023 14:49:58 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A963E40FD0;
Tue, 28 Nov 2023 14:49:58 +0100 (CET)
Message-ID: <a8fe4604-3fc6-423f-8371-dd49b44a969f@proxmox.com>
Date: Tue, 28 Nov 2023 14:49:58 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, Philipp Hufnagl <p.hufnagl@proxmox.com>
References: <20231128104022.240113-1-p.hufnagl@proxmox.com>
<20231128104022.240113-3-p.hufnagl@proxmox.com>
Content-Language: en-US
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <20231128104022.240113-3-p.hufnagl@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.018 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
Subject: Re: [pbs-devel] [PATCH proxmox-backup v3 2/3] ui: Show if Filter
includes or excludes
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 28 Nov 2023 13:50:29 -0000
On 11/28/23 11:40, Philipp Hufnagl wrote:
[snip]
> @@ -384,6 +413,82 @@ Ext.define('PBS.form.GroupFilter', {
> },
> });
>
> +Ext.define('PBS.form.pbsGroupBehaviorSelector', {
> + extend: 'Proxmox.form.KVComboBox',
> + alias: 'widget.pbsGroupBehaviorSelector',
> +
> + allowBlank: false,
> +
> + comboItems: [
> + ['include', gettext('Include')],
> + ['exclude', gettext('Exclude')],
> + ],
> +});
> +Ext.define('PBS.form.GroupFilterGrid', {
> + extend: 'Ext.grid.Panel',
> + alias: 'widget.pbsGroupFilterGrid',
> +
> + scrollable: true,
> + height: 200,
> + store: {
> + fields: ['type', 'input'],
> + },
> + columns: [
> + {
> + text: gettext('Filter Type'),
> + xtype: 'widgetcolumn',
> + dataIndex: 'type',
> + flex: 1,
> + widget: {
> + xtype: 'pbsGroupFilterTypeSelector',
> + isFormField: false,
> + },
> + },
> + {
> + text: gettext('Filter Value'),
> + xtype: 'widgetcolumn',
> + flex: 1,
> + onWidgetAttach: 'newInputColumn',
> + widget: {
> + padding: 0,
> + bodyPadding: 0,
> + xtype: 'fieldcontainer',
> + layout: 'fit',
> + defaults:
> + {
> + margin: 0,
> + },
> + items: [
> + {
> + hidden: true,
> + xtype: 'pbsGroupTypeSelector',
> + isFormField: false,
> + },
> + {
> + hidden: true,
> + xtype: 'textfield',
> + type: 'regex',
> + isFormField: false,
> + },
> + {
> + hidden: true,
> + xtype: 'pbsGroupSelector',
> + isFormField: false,
> + },
> + ],
> + },
> + },
> + {
> + xtype: 'widgetcolumn',
> + width: 30,
here you change the width of the remove button, which makes it too narrow
and cuts of the icon, please leave the space of this the same as before
> + widget: {
> + xtype: 'button',
> + iconCls: 'fa fa-trash-o',
> + },
> + },
> + ],
> +});
> +
> Ext.define('PBS.form.GroupFilterTypeSelector', {
> extend: 'Proxmox.form.KVComboBox',
> alias: 'widget.pbsGroupFilterTypeSelector',