From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 11D331FF396 for ; Thu, 23 May 2024 09:51:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 733C91A59D; Thu, 23 May 2024 09:51:23 +0200 (CEST) Message-ID: Date: Thu, 23 May 2024 09:51:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox Backup Server development discussion , Thomas Lamprecht , Gabriel Goller References: <20240522131950.247728-1-g.goller@proxmox.com> <1b388e0c-1239-4f91-9273-c329180ff4ec@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <1b388e0c-1239-4f91-9273-c329180ff4ec@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [nist.rip, csf.tools, proxmox.com] Subject: Re: [pbs-devel] [PATCH backup/proxmox-backup 0/4] fix #5463: add optional consent banner before login X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 5/22/24 17:31, Thomas Lamprecht wrote: > Am 22/05/2024 um 15:19 schrieb Gabriel Goller: >> This has been requested many times already for all products. To keep >> it simple as it's still quite a niche feature, works with a single file: >> /etc/proxmox-backup/consent.txt. If the file exists and is not empty, >> a consent banner will be shown in front of the login view. >> >> This is just a reference implementation for pbs to get some feedback >> and check if my general approach is alright. The same implementation >> will then be ported to pve and eventually pmg. >> >> Another disclaimer: IANAL (I am not a lawyer :) ), so the wording is >> probably off. > > A few general questions for you and/or the original requester of this > feature: > > This is currently still missing any actual barrier as it's all frontend, > shouldn't there be a cookie that is checked on the backend side if a > consent.txt exist? If this specific consent type (RMF AC-8 for US gov) > doesn't need that, it might be worth to replace the generic text box > with a type selection for that, we could always add a "custom" type > that takes a generic text and extent that with an option about how > strict it should be checked, if we get this now. when checking https://csf.tools/reference/nist-sp-800-53/r5/ac/ac-8/ (not the "official" document, but very close , the original can be downloaded in docx form here: https://csrc.nist.rip/projects/risk-management/about-rmf/assess-step/assessment-cases-download-page) it does not seem to be necessary for any cookie handling since it just wants the disclaimer to be displayed before login > > And how should API calls made using API tokens get handled, should they > have a header signalling consent or not? If, should there be a set of > standard consents that one can explicitly consent too? As a blanket > consent to an unknown text would not be of much use. also it says that this is only for human interaction, so any api access etc. is exempt IIUC > > I'd in any way limit the length of the consent text to a relatively > high boundary, like 10 KiB. > > Did you think about interpreting and rendering this as Markdown? > > Did you check if there already exist (FLOSS) proxies that implement > this functionality by placing it between the user and any HTTP served > page/tool/ui, as that would not require us to do anything at all > (well, besides documenting it). > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel