From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40])
	by lore.proxmox.com (Postfix) with ESMTPS id 4A2301FF150
	for <inbox@lore.proxmox.com>; Mon, 06 Jul 2026 14:28:56 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 1A14621462;
	Mon, 06 Jul 2026 14:28:56 +0200 (CEST)
Message-ID: <a81ce561-b72c-4331-8dc7-d4029c3b32d5@proxmox.com>
Date: Mon, 6 Jul 2026 14:28:21 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Robert Obkircher <r.obkircher@proxmox.com>
Subject: Re: [PATCH proxmox-backup v3 07/15] pbs-config: drop backup_group
 helper, use users gid instead
To: Christian Ebner <c.ebner@proxmox.com>, pbs-devel@lists.proxmox.com
References: <20260701140412.200920-1-c.ebner@proxmox.com>
 <20260701140412.200920-8-c.ebner@proxmox.com>
Content-Language: en-US, de-AT
In-Reply-To: <20260701140412.200920-8-c.ebner@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1783340895331
X-SPAM-LEVEL: Spam detection results:  0
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: T2O3JA4VBM4WSUZCX3HUTRSDFYZGVI5X
X-Message-ID-Hash: T2O3JA4VBM4WSUZCX3HUTRSDFYZGVI5X
X-MailFrom: r.obkircher@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pbs-devel-owner@lists.proxmox.com>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Subscribe: <mailto:pbs-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pbs-devel-leave@lists.proxmox.com>


On 01.07.26 16:04, Christian Ebner wrote:
> Use the gid as reported for the backup user, which matches the
> `backup` group anyways. By this it is possible to use the user
> provided via proxmox-product-config::get_api_user() for chunk store
> operations instead, avoiding expensive user/group lookups.
>
> [..]
>  
> -/// Return Group info for the 'backup' group (``getgrnam(3)``)
> -pub fn backup_group() -> Result<nix::unistd::Group, Error> {
> -    if cfg!(test) {
> -        Ok(Group::from_gid(Gid::current())?.expect("current group does not exist"))
> -    } else {
> -        Group::from_name(BACKUP_GROUP_NAME)?
> -            .ok_or_else(|| format_err!("Unable to lookup '{}' group.", BACKUP_GROUP_NAME))
> -    }
> -}
> -
> [..]

It looks like this was the only use of BACKUP_GROUP_NAME, so it could
be deleted as well.