From: Dominik Csapak <d.csapak@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix #5233: don't require root for some tape operations
Date: Wed, 13 Nov 2024 08:42:22 +0100 [thread overview]
Message-ID: <a6fefdc4-8983-4575-a56b-78f15f1b29fc@proxmox.com> (raw)
In-Reply-To: <68d6639e-a27d-4198-be2e-6a423a78581f@proxmox.com>
On 11/12/24 21:15, Thomas Lamprecht wrote:
> Am 10.09.24 um 09:08 schrieb Dominik Csapak:
>> instead, require 'Tape.Write' on '/tape' path.
>> This makes it possible for a TapeAdmin or TapeOperator to
>> format/remove/vault tapes, instead of just root@pam.
>>
>> I opted for the path '/tape' since we don't have a dedicated acl
>> structure for single tapes, just '/tape/pool' (which does not apply
>> since not all tapes have to have a pool), '/tape/device' (which is
>> intended for drives/changers) and '/tape/jobs' (which is for jobs only).
>>
>> Alternatively we could invent a new scheme for tape media, e.g.
>> '/tape/media' for this.
>
> the path is fine, but why Tape.Write over Tape.Modify?
>
>> Tape.Modify
>> Tape.Modify allows a user to modify the configuration of tape drives, changers and backups.
>
> vs
>
>> Tape.Write
>> Tape.Write allows a user to write to a tape media.
>
> The former might be a better fit here as these calls alter not only the tape
> content, or?
>
> Noticed because Hannes' recent patch already switched the move-tape one to
> Tape.Modify,
>
mhmm... not sure why i chose Tape.Write exactly, but IMHO looking at it again, Modify would probably
fit better for the 'update_media_status' (also fits better for the move-tape as Hannes rightly
noticed)
for destroy I'd be inclined to still use Write. While it does update the inventory
(it removes it from there), It's basically the inverse of 'format_media' (as
in, that inserts it into the inventory) which also uses Write.
I'd send a rebased version for using Write for destroy, and Modify for update status if that's
fine with you.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-11-13 7:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 7:08 Dominik Csapak
2024-11-12 20:15 ` Thomas Lamprecht
2024-11-13 7:42 ` Dominik Csapak [this message]
2024-11-13 8:25 ` Thomas Lamprecht
2024-11-13 11:38 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6fefdc4-8983-4575-a56b-78f15f1b29fc@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox