From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 167B970DAF for ; Tue, 6 Apr 2021 09:42:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 134422AA04 for ; Tue, 6 Apr 2021 09:42:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E60A82A9F7 for ; Tue, 6 Apr 2021 09:42:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B2D4745784 for ; Tue, 6 Apr 2021 09:42:14 +0200 (CEST) To: Dietmar Maurer , Proxmox Backup Server development discussion References: <147179381.645.1617694207013@webmail.proxmox.com> From: Dominik Csapak Message-ID: Date: Tue, 6 Apr 2021 09:42:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <147179381.645.1617694207013@webmail.proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.171 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 00/12] clippy fixes X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Apr 2021 07:42:16 -0000 On 4/6/21 9:30 AM, Dietmar Maurer wrote: > IO am currently rewriting large parts of the tape driver, so > this is a bad time for clippy fixes... nvm then, it was just tedious to check my own code with clippy with those warnings/errors in place. i'll happily send another round of these later when you're done > >> On 04/06/2021 8:27 AM Dominik Csapak wrote: >> >> >> various clippy fixes all over the place >> if the separation is not ok, i can send them ofc separated >> differently >> >> (they were not too many of the same type to group by warning, >> and too spread out to group by file, so i settled for some middle >> ground) >> >> Dominik Csapak (12): >> api2/tape: clippy fixes >> tape/changer: clippy fixes >> tape/drive: clippy fixes >> tape/media_*: clippy fixes >> tape/pool_writer: clippy fixes >> backup: clippy fixes >> pxar: clippy fix `or_fun_call` >> bin: clippy fixes >> tape/*: clippy fixes >> tools: clippy fixes >> config/tape_encryption_keys: clippy fixes >> server/worker_task: clippy fix >> >> src/api2/config/tape_backup_job.rs | 1 + >> src/api2/tape/backup.rs | 2 +- >> src/api2/tape/media.rs | 42 ++++++++++---------- >> src/api2/tape/restore.rs | 12 +++--- >> src/backup/key_derivation.rs | 6 +-- >> src/backup/manifest.rs | 1 + >> src/bin/docgen.rs | 2 +- >> src/bin/pmt.rs | 2 +- >> src/bin/pmtx.rs | 2 +- >> src/config/tape_encryption_keys.rs | 8 ++-- >> src/pxar/extract.rs | 4 +- >> src/server/worker_task.rs | 2 +- >> src/tape/changer/online_status_map.rs | 4 +- >> src/tape/changer/sg_pt_changer.rs | 2 +- >> src/tape/drive/linux_tape.rs | 2 +- >> src/tape/drive/mam.rs | 12 +++--- >> src/tape/drive/mod.rs | 4 +- >> src/tape/drive/virtual_tape.rs | 2 +- >> src/tape/file_formats/multi_volume_writer.rs | 2 +- >> src/tape/inventory.rs | 2 +- >> src/tape/media_catalog.rs | 10 +++-- >> src/tape/media_pool.rs | 16 +++----- >> src/tape/media_set.rs | 4 ++ >> src/tape/pool_writer/catalog_set.rs | 1 + >> src/tape/pool_writer/mod.rs | 4 +- >> src/tape/pool_writer/new_chunks_iterator.rs | 4 +- >> src/tools/fs.rs | 3 ++ >> src/tools/sgutils2.rs | 18 ++++----- >> 28 files changed, 93 insertions(+), 81 deletions(-) >> >> -- >> 2.20.1 >> >> >> >> _______________________________________________ >> pbs-devel mailing list >> pbs-devel@lists.proxmox.com >> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel