From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3658562E05 for ; Fri, 18 Sep 2020 15:26:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 26003165F4 for ; Fri, 18 Sep 2020 15:26:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 900DA165E7 for ; Fri, 18 Sep 2020 15:26:51 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 56D25419B4 for ; Fri, 18 Sep 2020 15:26:51 +0200 (CEST) To: Proxmox Backup Server development discussion , Hannes Laimer References: <20200918090052.79979-1-h.laimer@proxmox.com> <20200918090052.79979-6-h.laimer@proxmox.com> From: Thomas Lamprecht Message-ID: Date: Fri, 18 Sep 2020 15:26:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:81.0) Gecko/20100101 Thunderbird/81.0 MIME-Version: 1.0 In-Reply-To: <20200918090052.79979-6-h.laimer@proxmox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.190 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH v2 proxmox-backup 5/6] ui: add verify-schedule field to edit datastore form X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Sep 2020 13:26:52 -0000 On 9/18/20 11:00 AM, Hannes Laimer wrote: > Signed-off-by: Hannes Laimer > --- > www/config/DataStoreConfig.js | 5 +++-- > www/window/DataStoreEdit.js | 9 +++++++++ > 2 files changed, 12 insertions(+), 2 deletions(-) > > diff --git a/www/config/DataStoreConfig.js b/www/config/DataStoreConfig.js > index 54d7a505..685d3d5f 100644 > --- a/www/config/DataStoreConfig.js > +++ b/www/config/DataStoreConfig.js > @@ -11,8 +11,9 @@ Ext.define('pbs-datastore-list', { > Ext.define('pbs-data-store-config', { > extend: 'Ext.data.Model', > fields: [ > - 'name', 'path', 'comment', 'gc-schedule', 'prune-schedule', 'keep-last', > - 'keep-hourly', 'keep-daily', 'keep-weekly', 'keep-monthly', 'keep-yearly', > + 'name', 'path', 'comment', 'gc-schedule', 'prune-schedule', > + 'verify-schedule', 'keep-last', 'keep-hourly', 'keep-daily', > + 'keep-weekly', 'keep-monthly', 'keep-yearly', > ], > proxy: { > type: 'proxmox', > diff --git a/www/window/DataStoreEdit.js b/www/window/DataStoreEdit.js > index adb857ab..926a8a19 100644 > --- a/www/window/DataStoreEdit.js > +++ b/www/window/DataStoreEdit.js > @@ -71,6 +71,15 @@ Ext.define('PBS.DataStoreEdit', { > deleteEmpty: '{!isCreate}', > }, > }, > + { > + xtype: 'pbsCalendarEvent', > + name: 'verify-schedule', > + fieldLabel: gettext("Verify Schedule"), > + emptyText: gettext('none'), > + cbind: { > + deleteEmpty: '{!isCreate}', > + }, > + }, > ], > columnB: [ > { > just as a note, respective column is missing from the datastore configuration grid. But, see also my and Dominik's other mail about the different, more flexible and less crowded approach to list/manage schedules.