From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 85AAA1FF16F for ; Tue, 22 Jul 2025 14:31:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 425DF8F69; Tue, 22 Jul 2025 14:32:54 +0200 (CEST) Message-ID: Date: Tue, 22 Jul 2025 14:32:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Lukas Wagner , Proxmox Backup Server development discussion References: <20250722101106.526438-1-c.ebner@proxmox.com> <20250722101106.526438-8-c.ebner@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753187531798 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.044 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup v11 03/46] api: config: implement endpoints to manipulate and list s3 configs X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 7/22/25 2:18 PM, Lukas Wagner wrote: > On Tue Jul 22, 2025 at 12:10 PM CEST, Christian Ebner wrote: >> + >> +#[api( >> + input: { >> + properties: { >> + id: { >> + schema: JOB_ID_SCHEMA, >> + }, >> + }, >> + }, >> + returns: { type: S3ClientConfig }, >> + access: { >> + permission: &Permission::Privilege(&[], PRIV_SYS_AUDIT, false), >> + }, >> +)] >> +/// Read an s3 client configuration. >> +pub fn read_s3_client_config( >> + id: String, >> + rpcenv: &mut dyn RpcEnvironment, >> +) -> Result { >> + let (config, digest) = s3::config()?; >> + let s3_client_config: S3ClientConfig = config.lookup(S3_CFG_TYPE_ID, &id)?; >> + rpcenv["digest"] = hex::encode(digest).into(); >> + >> + Ok(s3_client_config) >> +} > > Hmm, maybe we should mask the secret_key in the response? Usually we > don't return any secrets from the API. Oh, right, will have a look how we handle this normally, e.g. for the remotes. _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel