From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B171A7762C for ; Tue, 20 Jul 2021 19:26:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9CDC3D106 for ; Tue, 20 Jul 2021 19:25:38 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7BE36D0F5 for ; Tue, 20 Jul 2021 19:25:37 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1BD8541B65 for ; Tue, 20 Jul 2021 19:25:37 +0200 (CEST) Message-ID: Date: Tue, 20 Jul 2021 19:25:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Dietmar Maurer References: <20210720115158.376164-1-dietmar@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210720115158.376164-1-dietmar@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.167 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [openid.rs] Subject: [pbs-devel] applied-series: [PATCH proxmox-apt] depend on proxmox 0.12.0, bump version to 0.5.1-1 X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jul 2021 17:26:08 -0000 applied series, had to do a few fixups though: * bump proxmox-api-macro and proxmox-http as they both use proxmox and are already present in PBS 1.X based on Buster, so we need some version room for doing stable updates there * squashed in d/control updates in proxmox-apt in your commit * fixed proxmox-backup's d/control, we do not use debcargo anymore there, so it needs to be adapted manual for now (could and should be automated though) * fixed the use in openid `src/api2/access/openid.rs` which was probably missed as it's behind the "openid" cargo "cfg" flag and no full `make deb` or `cargo build --cfg openid` was done. I squashed the change into your patch, IMO there was no need for a separate fixup commit here. One thing I do not really like is the name of the helper, as `open_backup_lockfile` sounds like it would open the lockfile of a backup (snapshot), but that's not the case. IMO the backup is irrelevant here, we just have a privileged and unprivileged user, here it's `backup` in PVE `www-data`, the actual user does not matters much for the code, and even if the name would still be confusing. I'd use rather a name like `open_lockfile_unpriv`, but as this is all contained to that one repo it can be changed at any time, so I applied it as is for now. ps. the patches are lacking your `Signed-off-by`, no biggie currently, but we try to add that nonetheless, thanks!