From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1CA5B70FA3 for ; Mon, 17 May 2021 10:59:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 11BD529738 for ; Mon, 17 May 2021 10:59:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 9AB6A2972A for ; Mon, 17 May 2021 10:59:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6D06146558 for ; Mon, 17 May 2021 10:59:03 +0200 (CEST) To: Proxmox Backup Server development discussion , Dominik Csapak References: <20210517070315.4510-1-d.csapak@proxmox.com> From: Dietmar Maurer Message-ID: Date: Mon, 17 May 2021 10:59:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210517070315.4510-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-SPAM-LEVEL: Spam detection results: 0 AWL 0.212 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: datastore/Content: fix wrong tooltip for forgetting X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 May 2021 08:59:04 -0000 applied both patches On 5/17/21 9:03 AM, Dominik Csapak wrote: > sometimes it's a group, not a snapshot > > Signed-off-by: Dominik Csapak > --- > www/datastore/Content.js | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/www/datastore/Content.js b/www/datastore/Content.js > index 67ebbdac..ca90f82a 100644 > --- a/www/datastore/Content.js > +++ b/www/datastore/Content.js > @@ -632,7 +632,9 @@ Ext.define('PBS.DataStoreContent', { > }, > { > handler: 'onForget', > - getTip: (v, m, rec) => Ext.String.format(gettext("Permanently forget snapshot '{0}'"), v), > + getTip: (v, m, rec) => rec.parentNode.id !=='root' > + ? Ext.String.format(gettext("Permanently forget snapshot '{0}'"), v) > + : Ext.String.format(gettext("Permanently forget group '{0}'"), v), > getClass: (v, m, rec) => !rec.data.leaf ? 'fa critical fa-trash-o' : 'pmx-hidden', > isDisabled: (v, r, c, i, rec) => !!rec.data.leaf, > },