From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 357A99E6A1 for ; Mon, 27 Nov 2023 17:29:43 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 19BC6B5FC for ; Mon, 27 Nov 2023 17:29:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 27 Nov 2023 17:29:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5E55E44C0E for ; Mon, 27 Nov 2023 17:29:12 +0100 (CET) Message-ID: Date: Mon, 27 Nov 2023 17:29:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Lukas Wagner To: Proxmox Backup Server development discussion , Markus Frank References: <20231110135010.106015-1-m.frank@proxmox.com> <20231110135010.106015-6-m.frank@proxmox.com> Content-Language: de-AT, en-US In-Reply-To: <20231110135010.106015-6-m.frank@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.008 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup 6/6] prohibit disk wipe of EFI partition X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Nov 2023 16:29:43 -0000 On 11/10/23 14:50, Markus Frank wrote: > Signed-off-by: Markus Frank > --- > This patch is based on a suggestion by Dominik. > I am not so sure if we should prohibit wiping EFI partitions. > Any opinions on this? > > src/tools/disks/mod.rs | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/src/tools/disks/mod.rs b/src/tools/disks/mod.rs > index 75d84696..8a28159e 100644 > --- a/src/tools/disks/mod.rs > +++ b/src/tools/disks/mod.rs > @@ -1071,6 +1071,12 @@ pub fn wipe_blockdev(disk: &Disk) -> Result<(), Error> { > for disk_i in get_lsblk_info()?.iter() { > if disk_i.path == disk_path.to_str().unwrap() && disk_i.partition_type.is_some() { > is_partition = true; > + if matches!( > + disk_i.partition_type.as_deref(), > + Some("c12a7328-f81f-11d2-ba4b-00a0c93ec93b") Maybe add some comment on what this magic string means, e.g. with a link to some spec that defines that? Could also extract the string into a local constant with a good name (e.g. EFI_PARTITION_TYPE, or something alike), that would maybe be a bit nicer to read. > + ) { > + bail!("You will not be able to boot if you wipe the EFI partition."); > + } > } > } > -- - Lukas