From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 152FC74A6F for ; Wed, 2 Jun 2021 17:09:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 04A70DB65 for ; Wed, 2 Jun 2021 17:09:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7F9E9DB56 for ; Wed, 2 Jun 2021 17:09:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4E02A466EA for ; Wed, 2 Jun 2021 17:09:04 +0200 (CEST) Message-ID: Date: Wed, 2 Jun 2021 17:09:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101 Thunderbird/89.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Dominik Csapak References: <20210602121919.31852-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210602121919.31852-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.017 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [mod.rs, backup.rs] Subject: [pbs-devel] applied: [PATCH proxmox-backup v2] tape/drive: improve tape device locking behaviour X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jun 2021 15:09:09 -0000 On 02.06.21 14:19, Dominik Csapak wrote: > by implementing a custom error type that is either 'TimeOut' or > 'Other'. > > In the api, check in the worker loop for exactly 'TimeOut' errors and continue only > then. All other errors lead to a aborted task. > > Signed-off-by: Dominik Csapak > --- > changes from v1: > * implement custom error types, so that we can detect the one > special error condition more cleanly > > src/api2/tape/backup.rs | 14 +++++++++----- > src/tape/drive/mod.rs | 34 +++++++++++++++++++++++++++++----- > 2 files changed, 38 insertions(+), 10 deletions(-) > > applied, thanks!