From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ronja.mits.lan by ronja.mits.lan with LMTP id uLUBCcFUeWbtYwAAxxbTJA (envelope-from ); Mon, 24 Jun 2024 13:13:05 +0200 Received: from proxmox-new.maurer-it.com (unknown [192.168.2.33]) by ronja.mits.lan (Postfix) with ESMTPS id 09877F6462A; Mon, 24 Jun 2024 13:13:05 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E204B4858E; Mon, 24 Jun 2024 13:13:04 +0200 (CEST) Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by proxmox-new.maurer-it.com (Proxmox) with ESMTPS; Mon, 24 Jun 2024 13:13:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BFA9C35095; Mon, 24 Jun 2024 13:13:03 +0200 (CEST) Message-ID: Date: Mon, 24 Jun 2024 13:13:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox Backup Server development discussion , Gabriel Goller References: <20240613135623.279167-1-g.goller@proxmox.com> Content-Language: de-AT, en-US From: Lukas Wagner In-Reply-To: <20240613135623.279167-1-g.goller@proxmox.com> Subject: Re: [pbs-devel] [PATCH proxmox{, -backup} v5 0/4] proxmox-log introduction X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" X-SPAM-LEVEL: Spam detection results: 0 DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods MAILING_LIST_MULTI -2 Multiple indicators imply a widely-seen list manager RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record On 2024-06-13 15:56, Gabriel Goller wrote: > Removed the task_log! (and friends task_warn!, task_debug!, etc.) macro > and introduced the `tracing` crate. We now initiate the tracing crate > using a single layer, which is logging to the syslog and the tasklog. > It uses the `syslog` crate and the original `FileLogger`. > > To write to the task logs from the worker threads and tasks, we now > have a task_local logger (and warning counter), which > will get instantiated when a task/thread is created. This means that > when we call `info!` or any other `tracing` log macros, it will get > the file_logger from TLS and write to the file. > > > > Summary over all repositories: > 46 files changed, 828 insertions(+), 1046 deletions(-) > Great work! Applied this on latest master and did a quick sanity check to ensure that (task) logging still works. I left some comments with a few minor things to improve. With those fixed, consider this: Tested-by: Lukas Wagner Reviewed-by: Lukas Wagner -- - Lukas _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel