From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D04789ED35 for ; Tue, 28 Nov 2023 15:20:11 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B2D9F183ED for ; Tue, 28 Nov 2023 15:20:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 28 Nov 2023 15:20:10 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4490840FD0 for ; Tue, 28 Nov 2023 15:20:10 +0100 (CET) Message-ID: Date: Tue, 28 Nov 2023 15:20:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: de-AT, en-US To: Proxmox Backup Server development discussion , Markus Frank References: <20231128132323.162721-1-m.frank@proxmox.com> From: Lukas Wagner In-Reply-To: <20231128132323.162721-1-m.frank@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.008 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup v3 0/6] fix #3690: wipe disk X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Nov 2023 14:20:11 -0000 On 11/28/23 14:23, Markus Frank wrote: > Wipe a disk/partition like we do in PVE. (wipefs, dd, change_parttype to 0x83 > with sgdisk) > Looks good to me now, my comments from the first review have been addressed and everything seems to work as expected. Tested wiping individual partitions as well as whole disks. EFI disks are protected (maybe this should be done with BIOS Boot partitions as well?) from accidental wipes. The task log could be improved (e.g. printing the actual commands that were executed, 'wipe disk /sdx' is printed twice), but this can happen in a followup IMO. Tested-by: Lukas Wagner Reviewed-by: Lukas Wagner -- - Lukas